| commit | 9cf5e51988c76975cf874b94405e19142e36773f | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Tue Apr 30 12:50:38 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Apr 30 12:50:38 2019 +0000 |
| tree | 182f7676ae091aac0c35e0df76261ea2524f689e | |
| parent | 43937aa9ca158e7f571f924abb10783a6bc28829 [diff] |
Consolidate test usage of ExpressionChecks.nullCheck into a single method. This should make it easier to refactor the migration logic without having to change tests too much. Note that there is a minor loss of test coverage: in test_functionInvocation_parameter_fromLocalParameter, we no longer verify that non-null intent is sufficent to force a check to occur. This is ok, because in future CLs, we will be simplifying the logic for deciding when to add null checks so that it occurs precisely when it's necessary to avoid a type mismatch. Once that change has been made, the correct behavior with non-null intent will happen automatically. Change-Id: I087c5c800fae3defa5b68380f05da40700af1359 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100793 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Dan Rubel <danrubel@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.