[vm] Fix deallocation of compressed heap When VirtualMemory object for the whole compressed pointers heap region is destroyed in VirtualMemory::~VirtualMemory(), it tests if the reservation address belongs to a compressed heap via VirtualMemoryCompressedHeap::Contains(reserved_.pointer()) If the heap region happens to be reserved at the 4GB aligned address by the O/S, then reservation address would match base address of the compressed pointers heap, and this check would pass and the whole reserved heap region would be passed to VirtualMemoryCompressedHeap::Free. However, the reservation size of the whole heap region is (8GB - 1 page) which is not aligned to kCompressedPageSize (512K). This would trigger assertion ASSERT(Utils::IsAligned(size, kCompressedPageSize)); inside VirtualMemoryCompressedHeap::Free. The fix is to detect when the whole compressed heap region is being destroyed and avoid calling VirtualMemoryCompressedHeap::Free as the region reserved for the whole heap is not managed by the compressed heap itself. TEST=python3 tools/test.py -n vm-win-debug-x64c --repeat 10000 co19/LibTest/typed_data/Uint32List/Uint32List.view_A01_t01 Fixes https://github.com/dart-lang/sdk/issues/51170 Change-Id: Icdf02eb0e2e3f39e435cba76fa647726bb383928 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352962 Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Liam Appelbe <liama@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.