| commit | 993b4caf0e0b7f094ef5bb2ce91152e8c0e1468e | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Thu May 24 21:56:25 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Thu May 24 21:56:25 2018 +0000 |
| tree | 36eda461dc089622c91c3e26bccba7ff15057f85 | |
| parent | 30ad3f66cef65f8aa37ac38faa0ab30b17b1001f [diff] |
Make the change to ContextRoot non-breaking. In 4cf51e6c1afd4d7863e1c0572a74a44b5269b106, a new argument was added to the ContextRoot constructor, changing its signature in a breaking way. In theory this should not have broken other packages, because ContextRoot is declared inside analyzer/lib/src. But it turns out that two packages are known to import from analyzer/lib/src and construct ContextRoot: angular_analyzer_plugin and built_value_generator. To avoid breaking these packages, we need to add the new constructor parameter as an optional (named) parameter. Some time after after angular_analyzer_plugin and built_value_generator have been updated, I'll send a later CL to mark the named parameter as @required. Change-Id: I5be063dd47a3dfefba08cb444687b91bf2ba3625 Reviewed-on: https://dart-review.googlesource.com/56603 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.