commit 9094075568225a5e56ecebdbda1031f0f4021961
author Ömer Sinan Ağacan <omersa@google.com> Fri Sep 06 13:36:48 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 06 13:36:48 2024 +0000
tree 87fdbad203410d0db551d6e7e5a6ed30a94548e7
parent 5833de865ff18f01608ee1eef030eb1e44fcbcd5

[dart2wasm] Minor refactoring in typed data

- Use precise types to buffer getters.

- Remove a redundant assignment in `_TypedListIterator.moveNext`.

- Use a more precise type in `_TypedListIterator._array`.

Change-Id: Ia8ebb796c66e7a91f73133b1d7fae894ca762cbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384000
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>

sdk/lib/_internal/wasm/lib/typed_data.dart

diff --git a/sdk/lib/_internal/wasm/lib/typed_data.dart b/sdk/lib/_internal/wasm/lib/typed_data.dart
index 6c4a0db..4fa4cba 100644
--- a/sdk/lib/_internal/wasm/lib/typed_data.dart
+++ b/sdk/lib/_internal/wasm/lib/typed_data.dart
@@ -64,12 +64,12 @@
 }
 
 final class _TypedListIterator<E> implements Iterator<E> {
-  final List<E> _array;
+  final TypedDataList<E> _array;
   final int _length;
   int _position;
   E? _current;
 
-  _TypedListIterator(List<E> array)
+  _TypedListIterator(TypedDataList<E> array)
       : _array = array,
         _length = array.length,
         _position = -1;
@@ -82,7 +82,6 @@
       _position = nextPosition;
       return true;
     }
-    _position = _length;
     _current = null;
     return false;
   }
@@ -2303,7 +2302,7 @@
 
   int get offsetInBytes => _offsetInElements;
 
-  ByteBuffer get buffer => _I8ByteBuffer(_data);
+  _I8ByteBuffer get buffer => _I8ByteBuffer(_data);
 }
 
 abstract class _WasmI16ArrayBase extends WasmTypedDataBase {
@@ -2321,7 +2320,7 @@
 
   int get offsetInBytes => _offsetInElements * 2;
 
-  ByteBuffer get buffer => _I16ByteBuffer(_data);
+  _I16ByteBuffer get buffer => _I16ByteBuffer(_data);
 }
 
 abstract class _WasmI32ArrayBase extends WasmTypedDataBase {
@@ -2339,7 +2338,7 @@
 
   int get offsetInBytes => _offsetInElements * 4;
 
-  ByteBuffer get buffer => _I32ByteBuffer(_data);
+  _I32ByteBuffer get buffer => _I32ByteBuffer(_data);
 }
 
 abstract class _WasmI64ArrayBase extends WasmTypedDataBase {
@@ -2357,7 +2356,7 @@
 
   int get offsetInBytes => _offsetInElements * 8;
 
-  ByteBuffer get buffer => _I64ByteBuffer(_data);
+  _I64ByteBuffer get buffer => _I64ByteBuffer(_data);
 }
 
 abstract class _WasmF32ArrayBase extends WasmTypedDataBase {
@@ -2375,7 +2374,7 @@
 
   int get offsetInBytes => _offsetInElements * 4;
 
-  ByteBuffer get buffer => _F32ByteBuffer(_data);
+  _F32ByteBuffer get buffer => _F32ByteBuffer(_data);
 }
 
 abstract class _WasmF64ArrayBase extends WasmTypedDataBase {
@@ -2393,7 +2392,7 @@
 
   int get offsetInBytes => _offsetInElements * 8;
 
-  ByteBuffer get buffer => _F64ByteBuffer(_data);
+  _F64ByteBuffer get buffer => _F64ByteBuffer(_data);
 }
 
 extension WasmI8ArrayBaseExt on _WasmI8ArrayBase {