commit | 3c34c8fa2fbca93bf2f3dc4451be60f03e1fb14d | [log] [tgz] |
---|---|---|
author | Paul Berry <paulberry@google.com> | Fri May 24 15:43:45 2019 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri May 24 15:43:45 2019 +0000 |
tree | c16c24763e82eac31c4a0e2d05fb5c940ec02363 | |
parent | 77f26030521c895fc395994b0f3663c82eb52695 [diff] |
Fix type substitution of "star" types. When performing type substitution, there are three types involved, the substitution site (`this` in TypeImpl.substitute2), the type we are replacing (`parameterType` in TypeImpl.substitute2), and the replacement type (`argumentType` in TypeImpl.substitute2). Previously, we only handled the nullabilities of `this` and `argumentType`. This CL adds support for the possibility that `parameterType` might have nullability "*". This happens because TypeParameterElement.type returns a star type, so for instance when subsituting `int` for `T` in `List<T>` to form `List<int>`, we are actually substituting `int` for `T*` in `List<T*>`. Change-Id: I0a61fdc47ec8aa205dc0c539c49ea7799ed4ac05 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103542 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web
Dart has flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
Visit the dart.dev to learn more about the language, tools, getting started, and more.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.