commit 8f2ca0b2482bf6acde1e90aab3745de407d4e51a
author Brian Wilkerson <brianwilkerson@google.com> Sat Mar 06 20:57:49 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Sat Mar 06 20:57:49 2021 +0000
tree 9050473658ccef39450295f2ef67ebbac70a907e
parent 637d4f84076faecbbf87c03e943a1bdce2ebe93f

Make markdown the only output option for the completion metrics tool

Change-Id: Id4c2020ea85453980f1ed044552b76f13316c7b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

pkg/analysis_server/tool/code_completion/completion_metrics.dart

diff --git a/pkg/analysis_server/tool/code_completion/completion_metrics.dart b/pkg/analysis_server/tool/code_completion/completion_metrics.dart
index cd32542..4b13c5a8 100644
--- a/pkg/analysis_server/tool/code_completion/completion_metrics.dart
+++ b/pkg/analysis_server/tool/code_completion/completion_metrics.dart
@@ -156,10 +156,6 @@
             'support in LSP.',
         defaultsTo: false,
         negatable: false)
-    ..addFlag(CompletionMetricsOptions.MD,
-        help: 'Use markdown as the output format.',
-        defaultsTo: false,
-        negatable: false)
     ..addOption(
       'help',
       abbr: 'h',
@@ -783,13 +779,8 @@
   }
 
   void printHeading(int level, String heading) {
-    if (options.markdown) {
-      var prefix = '#' * level;
-      print('$prefix $heading');
-    } else {
-      print(heading);
-      print(((level == 1) ? '=' : '-') * heading.length);
-    }
+    var prefix = '#' * level;
+    print('$prefix $heading');
     print('');
   }
 
@@ -818,6 +809,7 @@
       ['', 'mrr', 'inverse mrr', 'mrr_5', 'inverse mrr_5', 'count'],
       toRow(metrics.mrrComputer),
       toRow(metrics.successfulMrrComputer),
+      ['', '', '', '', '', ''],
       for (var group in groups) toRow(metrics.groupMrrComputers[group]),
     ];
     rightJustifyColumns(table, [2, 4, 5]);
@@ -1423,9 +1415,6 @@
   /// computing suggestions.
   static const String AVAILABLE_SUGGESTIONS = 'available-suggestions';
 
-  /// A flag that causes the output to be in markdown format.
-  static const String MD = 'md';
-
   /// An option to control whether and how overlays should be produced.
   static const String OVERLAY = 'overlay';
 
@@ -1473,9 +1462,6 @@
   /// run.
   final bool availableSuggestions;
 
-  /// A flag indicating whether the output should use markdown.
-  final bool markdown;
-
   /// The overlay mode that should be used.
   final String overlay;
 
@@ -1509,7 +1495,6 @@
   factory CompletionMetricsOptions(results) {
     return CompletionMetricsOptions._(
         availableSuggestions: results[AVAILABLE_SUGGESTIONS],
-        markdown: results[MD],
         overlay: results[OVERLAY],
         printMissedCompletionDetails: results[PRINT_MISSED_COMPLETION_DETAILS],
         printMissedCompletionSummary: results[PRINT_MISSED_COMPLETION_SUMMARY],
@@ -1521,7 +1506,6 @@
 
   CompletionMetricsOptions._(
       {@required this.availableSuggestions,
-      @required this.markdown,
       @required this.overlay,
       @required this.printMissedCompletionDetails,
       @required this.printMissedCompletionSummary,