| commit | 8e1c0bce3d41e16ac636c88b09f72fff3d1c4050 | [log] [tgz] |
|---|---|---|
| author | Alexander Markov <alexmarkov@google.com> | Thu Mar 20 10:20:31 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 20 10:20:31 2025 -0700 |
| tree | 45f587ca8a739582770484b4912233b80f80fac4 | |
| parent | c0e8f907e339ee6a055720ccc612d7d899bfd3f3 [diff] |
[vm,compiler] Fix incorrect handling of unwrapped phi in constant propagation When constant propagation evaluates EqualityCompare or StrictCompare, it can unwrap phis (if they are redundant wrt current set of reachable blocks), and calculate value if both lhs and rhs operands are the same. Previously, phi was marked as unwrapped only if that calculation changes the constant value of comparison. This is not correct as calculation based on unwrapped phi needs to be invalidated anyway if more reachable blocks are discovered and unwrapped phi becomes non-redundant. The fix is to mark the unwrapped phis regardless of whether the constant value of comparison has been changed or not. TEST=vm/dart/regress_60349_test Fixes https://github.com/dart-lang/sdk/issues/60349 Change-Id: I01e46d6def67fdc5d4c0bdc3a73aaac94725e221 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417021 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.