[analyzer] Remove unused, old feature methods from old parser
Change-Id: I08d3aa5b76546e449af42caffc2372e25bdd350a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/320440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/dart/analysis/file_state.dart b/pkg/analyzer/lib/src/dart/analysis/file_state.dart
index 88675c6..4add323 100644
--- a/pkg/analyzer/lib/src/dart/analysis/file_state.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/file_state.dart
@@ -721,7 +721,6 @@
featureSet: scanner.featureSet,
lineInfo: lineInfo,
);
- parser.enableOptionalNewAndConst = true;
var unit = parser.parseCompilationUnit(token);
unit.languageVersion = LibraryLanguageVersion(
diff --git a/pkg/analyzer/lib/src/generated/parser.dart b/pkg/analyzer/lib/src/generated/parser.dart
index f3698d7..69bbb12 100644
--- a/pkg/analyzer/lib/src/generated/parser.dart
+++ b/pkg/analyzer/lib/src/generated/parser.dart
@@ -51,15 +51,6 @@
astBuilder.allowNativeClause = value;
}
- bool get enableOptionalNewAndConst => false;
-
- set enableOptionalNewAndConst(bool enable) {}
-
- set enableSetLiterals(bool value) {
- // TODO(danrubel): Remove this method once the reference to this flag
- // has been removed from dart format.
- }
-
set parseFunctionBodies(bool parseFunctionBodies) {
astBuilder.parseFunctionBodies = parseFunctionBodies;
}
diff --git a/pkg/analyzer/test/generated/parser_test_base.dart b/pkg/analyzer/test/generated/parser_test_base.dart
index 1de892d..ba4126c 100644
--- a/pkg/analyzer/test/generated/parser_test_base.dart
+++ b/pkg/analyzer/test/generated/parser_test_base.dart
@@ -37,14 +37,6 @@
set allowNativeClause(bool value);
- /// Set a flag indicating whether the parser should parse instance creation
- /// expressions that lack either the `new` or `const` keyword.
- set enableOptionalNewAndConst(bool value);
-
- /// Set a flag indicating whether the parser is to parse part-of directives
- /// that specify a URI rather than a library name.
- set enableUriInPartOf(bool value);
-
/// The error listener to which scanner and parser errors will be reported.
///
/// This field is typically initialized by invoking [createParser].
@@ -228,19 +220,6 @@
bool allowNativeClause = false;
@override
- set enableOptionalNewAndConst(bool enable) {
- // ignored
- }
-
- @override
- set enableUriInPartOf(bool value) {
- if (value == false) {
- throw UnimplementedError(
- 'URIs in "part of" declarations cannot be disabled in Fasta.');
- }
- }
-
- @override
GatheringErrorListener get listener => parserProxy.errorListener;
@override
@@ -972,18 +951,6 @@
/// A flag indicating whether parser is to parse async.
bool parseAsync = true;
- /// A flag indicating whether the parser should parse instance creation
- /// expressions that lack either the `new` or `const` keyword.
- bool enableOptionalNewAndConst = false;
-
- /// A flag indicating whether the parser should parse mixin declarations.
- /// https://github.com/dart-lang/language/issues/12
- bool isMixinSupportEnabled = false;
-
- /// A flag indicating whether the parser is to parse part-of directives that
- /// specify a URI rather than a library name.
- bool enableUriInPartOf = false;
-
@override
late final GatheringErrorListener listener;
@@ -1029,7 +996,6 @@
);
parser.allowNativeClause = allowNativeClause;
parser.parseFunctionBodies = parseFunctionBodies;
- parser.enableOptionalNewAndConst = enableOptionalNewAndConst;
parser.currentToken = result.tokens;
}
@@ -1147,7 +1113,6 @@
featureSet: FeatureSets.latestWithExperiments,
lineInfo: lineInfo,
);
- parser.enableOptionalNewAndConst = enableOptionalNewAndConst;
CompilationUnit unit = parser.parseCompilationUnit(result.tokens);
expect(unit, isNotNull);
if (codes != null) {
@@ -1176,7 +1141,6 @@
featureSet: FeatureSet.latestLanguageVersion(),
lineInfo: lineInfo,
);
- parser.enableOptionalNewAndConst = enableOptionalNewAndConst;
var unit = parser.parseCompilationUnit(result.tokens);
return unit;
}
@@ -1455,7 +1419,6 @@
featureSet: FeatureSet.latestLanguageVersion(),
lineInfo: lineInfo,
);
- parser.enableOptionalNewAndConst = enableOptionalNewAndConst;
Statement statement = parser.parseStatement(result.tokens);
expect(statement, isNotNull);
return statement;
diff --git a/pkg/analyzer/test/generated/simple_parser_test.dart b/pkg/analyzer/test/generated/simple_parser_test.dart
index a5c7b35..87659d0 100644
--- a/pkg/analyzer/test/generated/simple_parser_test.dart
+++ b/pkg/analyzer/test/generated/simple_parser_test.dart
@@ -872,7 +872,6 @@
}
void test_parseInstanceCreation_keyword_33647() {
- enableOptionalNewAndConst = true;
CompilationUnit unit = parseCompilationUnit('''
var c = new Future<int>.sync(() => 3).then<int>((e) => e);
''');
@@ -886,7 +885,6 @@
}
void test_parseInstanceCreation_noKeyword_33647() {
- enableOptionalNewAndConst = true;
CompilationUnit unit = parseCompilationUnit('''
var c = Future<int>.sync(() => 3).then<int>((e) => e);
''');
@@ -900,7 +898,6 @@
}
void test_parseInstanceCreation_noKeyword_noPrefix() {
- enableOptionalNewAndConst = true;
createParser('f() => C<E>.n();');
CompilationUnit unit = parser.parseCompilationUnit2();
expect(unit, isNotNull);
@@ -918,7 +915,6 @@
}
void test_parseInstanceCreation_noKeyword_noPrefix_34403() {
- enableOptionalNewAndConst = true;
createParser('f() => C<E>.n<B>();');
CompilationUnit unit = parser.parseCompilationUnit2();
expect(unit, isNotNull);
@@ -935,7 +931,6 @@
}
void test_parseInstanceCreation_noKeyword_prefix() {
- enableOptionalNewAndConst = true;
createParser('f() => p.C<E>.n();');
CompilationUnit unit = parser.parseCompilationUnit2();
expect(unit, isNotNull);
@@ -952,7 +947,6 @@
}
void test_parseInstanceCreation_noKeyword_varInit() {
- enableOptionalNewAndConst = true;
createParser('''
class C<T, S> {}
void main() {final c = C<int, int Function(String)>();}
diff --git a/pkg/analyzer/test/generated/top_level_parser_test.dart b/pkg/analyzer/test/generated/top_level_parser_test.dart
index 68012af..9950247c8 100644
--- a/pkg/analyzer/test/generated/top_level_parser_test.dart
+++ b/pkg/analyzer/test/generated/top_level_parser_test.dart
@@ -2109,7 +2109,6 @@
}
void test_parsePartOfDirective_name() {
- enableUriInPartOf = true;
createParser("part of l;");
var directive = parseFullDirective() as PartOfDirective;
expect(directive.partKeyword, isNotNull);
@@ -2120,7 +2119,6 @@
}
void test_parsePartOfDirective_uri() {
- enableUriInPartOf = true;
createParser("part of 'lib.dart';");
var directive = parseFullDirective() as PartOfDirective;
expect(directive.partKeyword, isNotNull);
diff --git a/pkg/analyzer/test/src/dart/ast/parse_base.dart b/pkg/analyzer/test/src/dart/ast/parse_base.dart
index e8e2609..aa04e62 100644
--- a/pkg/analyzer/test/src/dart/ast/parse_base.dart
+++ b/pkg/analyzer/test/src/dart/ast/parse_base.dart
@@ -42,7 +42,6 @@
featureSet: featureSet,
lineInfo: lineInfo,
);
- parser.enableOptionalNewAndConst = true;
var unit = parser.parseCompilationUnit(token);
diff --git a/pkg/scrape/lib/scrape.dart b/pkg/scrape/lib/scrape.dart
index 28c49ae..882be34 100644
--- a/pkg/scrape/lib/scrape.dart
+++ b/pkg/scrape/lib/scrape.dart
@@ -280,8 +280,6 @@
// Parse it.
var parser = Parser(stringSource, errorListener,
featureSet: featureSet, lineInfo: lineInfo);
- parser.enableOptionalNewAndConst = true;
- parser.enableSetLiterals = true;
if (_printFiles) {
var line =
