| commit | 8a99ab0c74e80dbbafc5be51216371521c022d57 | [log] [tgz] |
|---|---|---|
| author | Daniel Hillerström <hillerstrom@google.com> | Mon Aug 27 13:32:30 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Mon Aug 27 13:32:30 2018 +0000 |
| tree | a6189435d1a4a4266d89ab96b019ded161bd6189 | |
| parent | f6242cb100125ce2fb71627401f91c8054b2be25 [diff] |
Fixes an illegal override in KernelUnresolvedNameGenerator.
The signature of the overridden method buildCompoundAssignment in
KernelUnresolvedNameGenerator (c.f. kernel_expression_generator.dart)
was illegal, because its (named parameter) arity was four, whilst the
same method in one of its supertypes has arity five.
Furthermore, there was a signature conflict for
buildCompoundAssignment amongst the supertypes of
KernelUnresolvedNameGenerator:
KernelUnresolvedNameGenerator
extends KernelGenerator
|
= Generator with KernelExpressionGenerator
|
arity(buildCompoundAssignment) = 5
with ErroneousExpressionGenerator, UnresolvedNameGenerator.
|
arity(buildCompoundAssignment) = 4
In this CL the conflict is resolved by the "greatest common
denominator" approach, that is, now each implementation of
buildCompoundAssignment has arity five.
This CL is a necessary step towards fixing
https://github.com/dart-lang/sdk/issues/34235
Related change: https://github.com/dart-lang/sdk/commit/c95ef874aa5f3231bcd0560e86ccc03bc5a49839
Change-Id: If1992b8fb2bb994f83557c48fb0ac276b2d1a8d3
Reviewed-on: https://dart-review.googlesource.com/71520
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.