)]}'
{
  "commit": "8218ee084081eded31d35aa79ae819d6656cffd4",
  "tree": "0bd6ab265e421b2657f3d3bc93f04b018539badb",
  "parents": [
    "1dfe2d889ba3aa5d202f7027c4480a45b81a7ec9"
  ],
  "author": {
    "name": "Daco Harkes",
    "email": "dacoharkes@google.com",
    "time": "Thu Mar 02 09:05:19 2023 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Mar 02 09:05:19 2023 +0000"
  },
  "message": "[cfe/ffi] Fix `Finalizable` in `for( in )` loops\n\nThe `Finalizable` visitor was visiting for-in loops in AST order:\n(1) variable, (2) iterable, (3) body. This caused the `variable` to be\nfenced in the `iterable` expression. The `variable` should only be\nfenced in the `body`.\n\nTEST\u003dtests/ffi/regress_51538_test.dart\nTEST\u003dpkg/vm/test/transformations/ffi_test.dart\n     with pkg/vm/testcases/transformations/ffi/regress_51538.dart\n\nCloses: https://github.com/dart-lang/sdk/issues/51538\nChange-Id: Idacf87b6de3ee0d2d5c6c5046060c55135593fed\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/286182\nAuto-Submit: Daco Harkes \u003cdacoharkes@google.com\u003e\nCommit-Queue: Daco Harkes \u003cdacoharkes@google.com\u003e\nReviewed-by: Slava Egorov \u003cvegorov@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3051332d5d18fdfe17a954950377dcbffaf1d99e",
      "old_mode": 33188,
      "old_path": "pkg/vm/lib/transformations/ffi/finalizable.dart",
      "new_id": "cb9043781176bc8c72cfbd7ef5ed7484449c2a7f",
      "new_mode": 33188,
      "new_path": "pkg/vm/lib/transformations/ffi/finalizable.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "28eb5149a8b1ee281d386ff6bf25a7807e994f44",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "634b390fb8b1cb884ad747935b33f1d5a7027972",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538.dart.aot.expect"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "73f8b65979523276e58c15162a0e38e0a7326a6c",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538.dart.expect"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "8201406a0fe50c4ba5af3630b62902292fb526d5",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538_2.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "0adc18c8ef354f7570013215074d7394c2feb1f9",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538_2.dart.aot.expect"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "db8611eac35f1c66d8951cc5a04d8adc5d313829",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538_2.dart.expect"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "6bbe4da20e4ac95ccd1078fa1f0e10db1451a621",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538_3.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "2b8c730f03692067ae1a74a4af3495d20755ffc4",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538_3.dart.aot.expect"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "f9520e3f5b217f268cccc9f3959ec2fa6710073d",
      "new_mode": 33188,
      "new_path": "pkg/vm/testcases/transformations/ffi/regress_51538_3.dart.expect"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "8201406a0fe50c4ba5af3630b62902292fb526d5",
      "new_mode": 33188,
      "new_path": "tests/ffi/regress_51538_2_test.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "6bbe4da20e4ac95ccd1078fa1f0e10db1451a621",
      "new_mode": 33188,
      "new_path": "tests/ffi/regress_51538_3_test.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "28eb5149a8b1ee281d386ff6bf25a7807e994f44",
      "new_mode": 33188,
      "new_path": "tests/ffi/regress_51538_test.dart"
    }
  ]
}