commit 968b6c27001c7225667f4f3a15582445250115cb
author Konstantin Shcheglov <scheglov@google.com> Thu Nov 06 07:27:19 2025 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 06 07:27:19 2025 -0800
tree 87217b4e3ac734fb8a99bf665edca6136e0cf1ee
parent 3500550ed25c082f2e6dddcd9aabe969cadb5a0a

Elements. Move type inference state from fragments to elements.

Store `typeInference` and `typeInferenceError` on
`PropertyInducingElementImpl` instead of on its fragments. There is only
one inference per variable/field, so keeping this state on the element
avoids duplication and ambiguity across fragments, and makes persistence
and comparison straightforward.

This change also persists `typeInferenceError` for fields and top-level
variables in summaries and manifests, so inference cycles and related
errors are stable across sessions and visible to matching/printing.

Key updates:
- Elements: add `typeInference` and `typeInferenceError` to
  `PropertyInducingElementImpl`; resolve `type` via element inference.
- Summary I/O: read/write `typeInferenceError` for field and top-level
  variable elements; bump `DATA_VERSION` to 584.
- Manifests: include `typeInferenceError` in `VariableItem` encoding,
  matching, and pretty printing.
- Linking/inference: produce and attach errors on the element (not the
  first fragment); clear element inference state on detach.
- Resolver/printers: read the error from the element and display it in
  element text output.

Behavior is unchanged for diagnostics, but the error state is now owned
by the element and consistently serialized, which prevents stale or
fragment-dependent mismatches and simplifies reasoning about inference
results.

Change-Id: Iec8ac0384171700fc7b7f568a4840c3f7d1ec0a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459961
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>