| commit | 80fb7891eba73cea1d6c5d8cfee80c09ddda39b1 | [log] [tgz] |
|---|---|---|
| author | Nicholas Shahan <nshahan@google.com> | Fri Jun 07 21:59:06 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Jun 07 21:59:06 2019 +0000 |
| tree | 891ea9518395cd490d84078df36f8c34cb054c70 | |
| parent | efaec6449d028d558afded9f65b39fa769a43747 [diff] |
Cleanup violation of `no_duplicate_case_values` lint Technically 'let' is an invalid identifier in ES6 strict mode. http://www.ecma-international.org/ecma-262/6.0/#sec-identifiers-static-semantics-early-errors We are never passing `strictMode = false` so either way it always returns true. Change-Id: I7891202d76dce621ee314dc583c6a44f916ab5b9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104382 Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Vijay Menon <vsm@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
diff --git a/pkg/dev_compiler/analysis_options.yaml b/pkg/dev_compiler/analysis_options.yaml index b2a090c..007c3e7 100644 --- a/pkg/dev_compiler/analysis_options.yaml +++ b/pkg/dev_compiler/analysis_options.yaml
@@ -22,6 +22,7 @@ - curly_braces_in_flow_control_structures - empty_constructor_bodies - library_names + - no_duplicate_case_values - null_closures - prefer_contains - prefer_equal_for_default_values
diff --git a/pkg/dev_compiler/lib/src/compiler/js_names.dart b/pkg/dev_compiler/lib/src/compiler/js_names.dart index 24d3dbd..ba120a3 100644 --- a/pkg/dev_compiler/lib/src/compiler/js_names.dart +++ b/pkg/dev_compiler/lib/src/compiler/js_names.dart
@@ -289,7 +289,6 @@ case "import": case "in": case "instanceof": - case "let": case "new": case "return": case "super":