| commit | 9070d6ae617b80b609449fcd8eabac06f7757d69 | [log] [tgz] |
|---|---|---|
| author | Aart Bik <ajcbik@google.com> | Tue Apr 16 19:07:15 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Apr 16 19:07:15 2019 +0000 |
| tree | ede00a7e938d7899d0377fcbaec197ea091d0a3c | |
| parent | 49607d13e2d6f5eb3b4bb8a6c0361589a863bf35 [diff] |
[dart/vm] Inspect shift constant in absence of range analysis Rationale: Queries the constant of a shift operation to determine if it is in range when range analysis has not run. This seems in general a good idea, since some optimizations occur *after* range analysis, and we were missing those cases. In this particular case, it also avoids an assert fail on a shift by one without env() that was introduced by a pass that has no subsequent range analysis. In this case, it is unclear whether not having an env() was an accident, or on purpose since the shift factor is known to be well-behaved. Please have a careful look! https://github.com/dart-lang/sdk/issues/36587 Change-Id: I12b4cb773f31899e17bfce8506bce599ccbef8ba Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99382 Commit-Queue: Aart Bik <ajcbik@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.