tree dc79970cfdb937ab2c4682f41bc5cf71333e0f98
parent a1401e3015571a76a9149395839208e5ce05f19d
author Jens Johansen <jensj@google.com> 1560252754 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1560252754 +0000

[cfe] Remember if finalizeExports was done

Before this CL, whenever a dill library builder was asked to compute
the outline it would finalize its exports - even if it was already done.
This is not really a problem (it mostly puts stuff into maps --- doing
it again will just overwrite what's already there with the same thing
again), but when having many dill library builders, and asking them to
compute the outline again and again because we've added a few new ones
(e.g. via kernel worker) it adds up to a lot of wasted time.

This CL adds a boolean to the dill library builders to avoid re-doing
this already done work.

An internal benchmark via kernel worker of lots of outline
calculations in worker mode with reuse and the incremental compiler
(and lots of dill loaded dependencies) goes from ~149 seconds to
~143 seconds.

Change-Id: I19cadbf64ff5e0ff117bad4df86c83832a1f28fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105243
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>