| commit | 7e792e7a8b32af95866a6d50769e02f90f6c2077 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Fri Jan 12 08:21:00 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 12 08:21:00 2024 +0000 |
| tree | 700e5e385f535f388e5356aa7b8e35836e9911b2 | |
| parent | 4532e20ec4752d9fb6cea9decd7a8e3250d0ce72 [diff] |
[kernel/DDC] Fix failing DDC tests; if finding no scope for offset find for a close previous offset instead When landing https://dart-review.googlesource.com/c/sdk/+/342400 the ddc-mac builder (but not Linux and Windows) started failing. I could reproduce on Linux though so I'm not sure why those builders didn't fail (nor why it wasn't caught by the try bot), either way this fixes the issues: * Test update: E.g. a breakpoint at the end of the scope doesn't work because it will not be inside the (wanted) scope. * Test update: Evalating "this" now actually works. * Scope finding update: DDC adds sourcemapping entries for the *end* of things so e.g. the getter "c" will have offset and offset+1 added as source mappings. When translating from javascript position to dart position we might pick that and thus ask for the scope of offset+1, but nothing will be found because no node has that offset. Here I add a fall-back saying that if we get no results we ask again for the nearest lower offset. Change-Id: I7e4430d9954466494b514cf51d999358483c9f8c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345501 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Anna Gringauze <annagrin@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.