commit 7d7af3bf0971ac2a1077bc5dab43783bfedee7f6
author Brian Quinlan <bquinlan@google.com> Tue Mar 04 08:07:14 2025 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 04 08:07:14 2025 -0800
tree 82e0a1cfb9036a0cfc1953b77061a0c148533d69
parent 388f22a88bc809b5938f3f1a70bb760ab3c65e4a

[io] Remove assertion for socket timeout exception contents.

Change-Id: I91648caa2d5e53013a1f53412ec5478f5bf4b719
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413326
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>

tests/standalone/io/secure_socket_test.dart

diff --git a/tests/standalone/io/secure_socket_test.dart b/tests/standalone/io/secure_socket_test.dart
index 687f436..05a4839 100644
--- a/tests/standalone/io/secure_socket_test.dart
+++ b/tests/standalone/io/secure_socket_test.dart
@@ -98,6 +98,8 @@
 void testConnectTimeout() {
   asyncStart();
   Duration timeout = new Duration(milliseconds: 0);
+  // TODO(https://github.com/dart-lang/sdk/issues/60246): ensure that the
+  // exception was really caused by a timeout.
   SecureSocket.connect("8.8.8.7", 80, timeout: timeout)
       .then((socket) {
         Expect.fail("Unexpected connection made.");
@@ -105,7 +107,6 @@
       })
       .catchError((e) {
         Expect.isTrue(e is SocketException);
-        Expect.equals(Platform.isWindows? 10060 : 110, (e as SocketException).osError?.errorCode);
         asyncEnd();
       });
 }

tests/standalone/io/socket_connect_timeout_test.dart

diff --git a/tests/standalone/io/socket_connect_timeout_test.dart b/tests/standalone/io/socket_connect_timeout_test.dart
index b2f7175..ada5cba 100644
--- a/tests/standalone/io/socket_connect_timeout_test.dart
+++ b/tests/standalone/io/socket_connect_timeout_test.dart
@@ -16,6 +16,8 @@
 void main() {
   asyncStart();
   Duration timeout = new Duration(milliseconds: 0);
+  // TODO(https://github.com/dart-lang/sdk/issues/60246): ensure that the
+  // exception was really caused by a timeout.
   Socket.connect("8.8.8.7", 80, timeout: timeout)
       .then((socket) {
         Expect.fail("Unexpected connection made.");
@@ -23,10 +25,6 @@
       })
       .catchError((e) {
         Expect.isTrue(e is SocketException);
-        Expect.equals(
-          Platform.isWindows ? 10060 : 110,
-          (e as SocketException).osError?.errorCode,
-        );
         asyncEnd();
       });
 }