tree 4750356a288f62253eb33f572ecd5ef9f8878ede
parent e04f5885b80453609334067101403b9c18f19893
author Daco Harkes <dacoharkes@google.com> 1651751315 +0000
committer Commit Bot <commit-bot@chromium.org> 1651751315 +0000

[vm] Only call `.hashCode` once when adding to `Map` and `Set`

The methods to add to hash maps and hash sets are recursive: if the
index needs to be rehashed then the same method is called again after
rehashing.

This CL nests the actual implementation in a private method that takes
the full hashCode as an extra argument.

No significant code size or run time changes are reported on our
benchmarks. (Our benchmarks do not contain purposefully slow hashCodes.)

Note that hashCode can be called again later if rehashing of the index
is required on adding subsequent elements.

Bug: https://github.com/dart-lang/sdk/issues/48948
Change-Id: Ia3ccff9e592d675b4922ac78c4aa7ee0287ecb50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243623
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>