| commit | 7d2ffd78de1f4ada1c7417339bb4e929059cbe3a | [log] [tgz] |
|---|---|---|
| author | Brian Wilkerson <brianwilkerson@google.com> | Sun Jun 06 16:07:31 2021 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Sun Jun 06 16:07:31 2021 +0000 |
| tree | a6f427830aa1d25010e05533ff3a4fed2ae149d2 | |
| parent | 7110872d91d3a4b386815e130cbe9c65d5b529fc [diff] |
Make correction producers know whether they can be bulk applied This change makes sense to me for a couple of reasons. First, when editing a correction producer the information about whether it can be bulk applied will be easier to find. Second, the information doesn't need to be duplicated when the producer can be applied to multiple error codes. And third, because the information is in one place we can't enable a producer in one place and miss enabling it in other places. This does have the unfortunate consequence that an extra producer needs to be created for bulk application in order to determine whether it should be applied at all, and can't be re-used because producers maintain state. We could consider storing a 'generator' object rather than a generator function in the map and have the `newInstance` methods produce those objects, but I'm not convinced that it's worthwhile given how short lived the extra producer is. There was also one subtle change that you probably won't see by looking at the changes, which is that one of the producers was enabled for bulk application for a lint but not enabled for several non-lint cases. It is now enabled everywhere. I remember thinking at the time that it should be fine, but I've forgotten which producer it was, so I can't easily tell you. If you want to confirm that change I'll be happy to do the work of figuring out which producer it is and which error codes were impacted by the change. Change-Id: I2010d777f727472c0d307a6948b84d37491e2b17 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202600 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.