| commit | 7882084ab5ac64a571fe6341ab6a3ba00fdc5829 | [log] [tgz] |
|---|---|---|
| author | Martin Kustermann <kustermann@google.com> | Mon May 19 06:46:18 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 19 06:46:18 2025 -0700 |
| tree | 9a1c46b79ec5f481c7de251fa245bc77b323d512 | |
| parent | 5ed14b257ffb43dfd389cb21f3238505281de3c0 [diff] |
[dart2wasm] Correctly deal with abstract members in selector building When we create a `Selector` we compute various information based on all members belonging to that selector. Before this CL this was split up: Some things like `ParameterInfo` was calculated&updated while discovering members, others was calculated after all members were discovered. We now make all fields whose value depends on knowing all members `late final` and initialize those fields after having found all members of a selector. When we compute the `ParameterInfo` of the selector we take special care: If there's non-abstract implementations and the selector is not overridable by dynamic modules then we create the `ParameterInfo` by looking only at the non-abstract members => This increases precision as we ignore the types and default values of optional parameters for abstract members If there's no implementations of the selector it may still be referred to by instance invocation AST nodes (which are unreachable). The current code generator still needs a `Selector.signature` in order to evaluate arguments for such nodes. => We calculate `ParameterInfo` based on the abstract member and use `defaultSentinel` for optional parameters. If a selector can have implementations in dynamic modules then we cannot determine whether all implementations have the same default value of optional parameters. => We calculate `ParameterInfo` using `defaultSentinel` value for all optional parameters. Ensuring the caller doesn't pass them but the callee will default to it's default value if it wasn't passed by caller. See added test case for when we (before this CL) may use unreachable members in the param info / signature calculation and how that could lead to a compiler bug (before this CL) due to a missing `VariableDeclaration.initializer` TEST=web/wasm/unreachable_selector_implementation_test Change-Id: I3628177f8e93c5d24ff0eb0ff8fee6121a4a08d1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428541 Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.