| commit | 7840675171e8dc2740312f0609518819ca9bf038 | [log] [tgz] |
|---|---|---|
| author | Vyacheslav Egorov <vegorov@google.com> | Tue Dec 18 16:46:03 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Dec 18 16:46:03 2018 +0000 |
| tree | 5f3b082a9fcf00c0d47d50bbb188afe625c6b4ef | |
| parent | 4163478f9b2ff47ed91d712eab42a373cfe624aa [diff] |
[vm] Fix vm/cc/ICDataTest: use release-store/acquire-load for array of ICData objects. Previous the test was accessing this array without any synchronization meaning that stores of new ICData objects into this array could be observed too early, before ICData object itself is initialized. Also add release/acquire in the code that attaches ICData map to the function - to ensure that if compiler thread sees ICData map then it is guaranteed to be fully initialized. Closes #34999 Change-Id: I95ba857122e2a5afed90b1518d591282e8255002 Reviewed-on: https://dart-review.googlesource.com/c/87583 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Auto-Submit: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.