tree d16a9992399bf4fecd3a90a68b4f750e673f6ce4
parent 15a444a0df2592b9f0f297930cc682bbac0d43c6
author Robert Nystrom <rnystrom@google.com> 1561501309 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1561501309 +0000

Refactor how test metadata is managed in test.dart.

There's a bunch of information that gets pulled from the contents of a
test file itself: whether it's a multitest, VMOptions, etc. Previously,
that lived in some combination of TestInformation objects and a big
stringly-typed "optionsFromFile" map that got passed everywhere. Also,
the map got mutated in a couple of choice places.

This replaces all of that with a single TestFile class that represents
all of the metadata gleaned from a given test file. This cleans up the
code base and also should pave the way for supporting static error
tests using that same class.

There should be no behavioral changes in this patch.

I didn't remove the packageRoot stuff in this change since there's
another change in flight for that. I'll merge those two together once
one of them lands.

Change-Id: Ia6d4c926afb342b71cb0041db7219586a792ac80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106581
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>