| commit | a7104c813fcc9b56d7b4f2bdde93d03f3a6e4613 | [log] [tgz] |
|---|---|---|
| author | Sigmund Cherem <sigmund@google.com> | Thu Oct 26 00:56:43 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 26 00:56:43 2023 +0000 |
| tree | 42e20a52a59c14f94572b33499d8d5b637a45995 | |
| parent | 097c84f11b04c48fc7a74965ff6f7e5e4175f8cd [diff] |
[tests] update periodic_timer tests to reduce flakiness. These tests check for lowerbounds on the time it took to fire an event. Unfortunately, browsers may complete events ahead of time. This has caused these tests to be flaky in dart2js and ddc [1] In a local experiment, we've seen timers complete +-15ms from the expected time. Most often they are around +-5ms, but those more extreme cases do happen. Recent flakiness logs show some good samples: * off by 1ms: [2] and [3] * off by 4ms: [4] * off by 13ms: [5] This CL makes two adjustments to reduce flakiness: * account for the fact that timers may complete early (checking that they are >= than the expected timeout - 40ms) * increase intervals to 50ms in order to prevent overlap between two events in the worse scenario that both happen on the extreme variances (+15ms and -15ms respectively). [1]: https://dart-current-results.web.app/#/filter=lib/async/periodic_timer,dart2js,ddc&showAll [2]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766776511992750881/+/u/test_results/ignored_flaky_test_failure_logs [3]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766798962026535617/+/u/test_results/ignored_flaky_test_failure_logs [4]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767378609439308945/+/u/test_results/ignored_flaky_test_failure_logs [5]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767357850408867553/+/u/test_results/ignored_flaky_test_failure_logs Change-Id: Ib46d6f33f5c2b1458f393e8b4c75c84453e73024 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331210 Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.