| commit | 73bd05df8ca1ddb221c31f203c2985471066579f | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Thu Oct 19 10:55:37 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 19 10:55:37 2023 +0000 |
| tree | 960101729ede5efdee7f0153812086710eb67f54 | |
| parent | d252bb11a342f011485b9c9fe7c56a246e92b12b [diff] |
[vm/compiler] Fix PhiUnboxingHeuristic::Process.
Fix IntConverterInstr::ComputeType() to return the Object CompileType,
not Int, if converting to a kUntagged representation. (This matches
the CompileType of a LoadFieldInstr loading a native untagged address
field.)
Similarly, change the type of LoadUntagged from Int to Object and
LoadThread from Dynamic to Object, since they also generate untagged
values.
In PhiUnboxingHeuristic::Process, start with the Phi node's existing
representation instead of kTagged. If any input of a Phi node is an untagged address, mark the Phi node as untagged, and let later
attempts to insert conversions fail if any other input is not.
TEST=vm/cc/ConstantPropagator_Regress35371
vm/dart/address_local_pointer_il_test
vm/dart/pointer_as_typed_list_il_test
ffi/extension_methods_test
ffi_2/extension_methods_test
Fixes: https://github.com/dart-lang/sdk/issues/53789
Cq-Include-Trybots: luci.dart.try:vm-linux-debug-x64c-try,vm-kernel-precomp-linux-release-x64-try,vm-win-debug-x64c-try,vm-asan-linux-release-x64-try,vm-aot-asan-linux-release-x64-try
Change-Id: I173b56022758413225c3fbf2b2ed8ac6b80ad7eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331060
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.