commit | 73b917c014f6b7160e85e0f5c3774833dd6f9507 | [log] [tgz] |
---|---|---|
author | Alexander Markov <alexmarkov@google.com> | Thu Apr 18 18:31:49 2019 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Thu Apr 18 18:31:49 2019 +0000 |
tree | 221c8006eca18e3f9e1e0cfc653907c3c40c8fdc | |
parent | 20fde9a6a863dd761b8875723fba6f8354751bd1 [diff] |
[vm/compiler] Do not generate unnecessary field length guards GuardFieldLengthInstr::EmitNativeCode aborts background compilation if we're not tracking list length for a field (guarded_list_length() == Field::kNoFixedLength). I'm seeing a lot of aborted background compilations on a Flutter app with the reason "GuardFieldLengthInstr: field state changed while compiling". This CL avoids generating these useless (and harmful) GuardFieldLengthInstr if not tracking list length for a field. Change-Id: I2a083c5df35e89893c9e787bebe4e3e7d8177c83 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99737 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Aart Bik <ajcbik@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.