tree 67c147866622bc1301e0b020a9f00d50f5343498
parent 507de0e2f5fbad4bff1df0910f06f1d971b07090
author Alexander Markov <alexmarkov@google.com> 1645814162 +0000
committer Commit Bot <commit-bot@chromium.org> 1645814162 +0000

[vm/compiler] Avoid unmatched representations after the last SelectRepresentations pass

Before this fix, Canonicalize pass could change representation
of inputs of EqualityCompare after the last SelectRepresentations
pass. This results in unmatched representations and invalid code
generated.

The fix is to disallow canonicalization of EqualityCompare
from null-aware to non-null-aware after the last SelectRepresentations.

TEST=vm/dart/regress_flutter98967_test
Fixes https://github.com/flutter/flutter/issues/98967

Change-Id: I05359737fe322fbb2a0fe6025e3716ba5d04ebbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234324
Reviewed-by: Slava Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>