Remove some dead code from analysis_server
Change-Id: I6407d800bca7f81e6bcf0fb1e0765e24fe310956
Reviewed-on: https://dart-review.googlesource.com/54980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analysis_server/lib/protocol/protocol.dart b/pkg/analysis_server/lib/protocol/protocol.dart
index 9e77ed7..730887e 100644
--- a/pkg/analysis_server/lib/protocol/protocol.dart
+++ b/pkg/analysis_server/lib/protocol/protocol.dart
@@ -14,26 +14,6 @@
export 'package:analyzer_plugin/protocol/protocol.dart' show Enum;
/**
- * A [RequestHandler] that supports [startup] and [shutdown] methods.
- *
- * Clients may not extend, implement or mix-in this class.
- */
-abstract class DomainHandler implements RequestHandler {
- /**
- * Perform any operations associated with the shutdown of the domain. It is
- * not guaranteed that this method will be called. If it is, it will be
- * called after the last [Request] has been made.
- */
- void shutdown() {}
-
- /**
- * Perform any operations associated with the startup of the domain. This
- * will be called before the first [Request].
- */
- void startup() {}
-}
-
-/**
* A notification that can be sent from the server about an event that occurred.
*
* Clients may not extend, implement or mix-in this class.
diff --git a/pkg/analysis_server/lib/src/domain_execution.dart b/pkg/analysis_server/lib/src/domain_execution.dart
index ea17e60..a58d1ae 100644
--- a/pkg/analysis_server/lib/src/domain_execution.dart
+++ b/pkg/analysis_server/lib/src/domain_execution.dart
@@ -2,7 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import 'dart:async';
import 'dart:collection';
import 'dart:core';
@@ -32,13 +31,7 @@
/**
* A table mapping execution context id's to the root of the context.
*/
- Map<String, String> contextMap = new HashMap<String, String>();
-
- /**
- * The subscription to the 'onAnalysisComplete' events,
- * used to send notifications when
- */
- StreamSubscription onFileAnalyzed;
+ final Map<String, String> contextMap = new HashMap<String, String>();
/**
* Initialize a newly created handler to handle requests for the given [server].
diff --git a/pkg/analysis_server/lib/src/plugin/notification_manager.dart b/pkg/analysis_server/lib/src/plugin/notification_manager.dart
index 9aad4d5..344697c 100644
--- a/pkg/analysis_server/lib/src/plugin/notification_manager.dart
+++ b/pkg/analysis_server/lib/src/plugin/notification_manager.dart
@@ -86,12 +86,12 @@
/**
* The object used to convert results.
*/
- ResultConverter converter = new ResultConverter();
+ final ResultConverter converter = new ResultConverter();
/**
* The object used to merge results.
*/
- ResultMerger merger = new ResultMerger();
+ final ResultMerger merger = new ResultMerger();
/**
* Initialize a newly created notification manager.
diff --git a/pkg/analysis_server/lib/src/status/diagnostics.dart b/pkg/analysis_server/lib/src/status/diagnostics.dart
index ac435fd..e51afef5 100644
--- a/pkg/analysis_server/lib/src/status/diagnostics.dart
+++ b/pkg/analysis_server/lib/src/status/diagnostics.dart
@@ -1310,19 +1310,5 @@
buf.write('$item');
});
}
-
- // execution domain
- ExecutionDomainHandler domain = server.handlers.firstWhere(
- (handler) => handler is ExecutionDomainHandler,
- orElse: () => null);
-
- h3('Execution domain');
- ul(ExecutionService.VALUES, (item) {
- if (domain.onFileAnalyzed != null) {
- buf.write('$item (has subscriptions)');
- } else {
- buf.write('$item (no subscriptions)');
- }
- });
}
}