tree 75b07ce26d2b9358ec95c56eb0f084e2b4dced86
parent b17cc1f9437bf26b7813e3febe1c3fd9ca49e88f
author Clement Skau <cskau@google.com> 1561557994 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1561557994 +0000

[VM] Fixes bug in CodeDeserial..::PostLoad due to Code::function.

This was triggered by 85360 which introduced external code observers
called during dart init.
The bug is however susceptible to racing as tests often shutdown the VM
before the code is fully deserialised.

Code::function() is deceptive as it does in fact not guarantee that its
return value is a Function. This in turn caused observer code to try access
non-exists members on not-actually-Functions.

Tested:
  tools/test.py -n dartk-asan-linux-debug-x64 vm/cc/DartAPI_DartInitializeCallsCodeObserver

Change-Id: I12e367be06a3630d2d401a37b9097273c13f31e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107289
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>