commit 71e17c37ddde4a028552a609921468d76abffb37
author Alexander Thomas <athom@google.com> Mon Jan 30 07:47:02 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 30 07:47:02 2023 +0000
tree 1b14abcba62ce9ac3e409e17f41e90351e767894
parent 5e24ca9d79cf2f5ebda82527008128dc4c4232cf

[infra] Rename null safe optcounter configs to eager-optimization

optcounter-threshold configs set the optimization-counter-threshold to 5
to make the VM optimize code eagerly. The "optcounter" name doesn't
inform users how the threshold was changed (a higher value would mean
"lazy" optimization).

Bug: b/201271877
Change-Id: Iaed0b9e601fc8d904c3847d9d26002c2bfa739dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279967
Reviewed-by: Slava Egorov <vegorov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>

tools/bots/test_matrix.json

diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json
index 354ef20..e0d0437 100644
--- a/tools/bots/test_matrix.json
+++ b/tools/bots/test_matrix.json
@@ -1053,7 +1053,7 @@
         ]
       }
     },
-    "vm-optcounter-(linux|mac|win)-(debug|product|release)-(ia32|x64|x64c|simarm|simarm64|simarm64c|simriscv32|simriscv64)": {
+    "vm-eager-optimization-(linux|mac|win)-(debug|product|release)-(ia32|x64|x64c|simarm|simarm64|simarm64c|simriscv32|simriscv64)": {
       "options": {
         "builder-tag": "optimization_counter_threshold",
         "vm-options": [
@@ -2946,17 +2946,17 @@
     },
     {
       "builders": [
-        "vm-optcounter-threshold-linux-release-ia32",
-        "vm-optcounter-threshold-linux-release-x64",
-        "vm-optcounter-threshold-linux-release-x64c",
-        "vm-optcounter-threshold-linux-release-simarm",
-        "vm-optcounter-threshold-linux-release-simarm64",
-        "vm-optcounter-threshold-linux-release-simarm64c",
-        "vm-optcounter-threshold-linux-release-simriscv32",
-        "vm-optcounter-threshold-linux-release-simriscv64"
+        "vm-eager-optimization-linux-release-ia32",
+        "vm-eager-optimization-linux-release-x64",
+        "vm-eager-optimization-linux-release-x64c",
+        "vm-eager-optimization-linux-release-simarm",
+        "vm-eager-optimization-linux-release-simarm64",
+        "vm-eager-optimization-linux-release-simarm64c",
+        "vm-eager-optimization-linux-release-simriscv32",
+        "vm-eager-optimization-linux-release-simriscv64"
       ],
       "meta": {
-        "description": "This is the configuration for the kernel optcounter builders, under the vm-kernel group. They run the same tests as the ordinary VM kernel builders, but add extra options to the vm."
+        "description": "This is the configuration for the VM builders with a lower optimization counter threshold."
       },
       "steps": [
         {
@@ -2969,7 +2969,7 @@
         {
           "name": "vm tests",
           "arguments": [
-            "-nvm-optcounter-linux-release-${arch}",
+            "-nvm-eager-optimization-linux-release-${arch}",
             "benchmark_smoke",
             "corelib",
             "ffi",