commit 71884477d2f1c57ac4875c2cc50ee66823a4c87c
author Konstantin Shcheglov <scheglov@google.com> Wed Feb 19 11:09:24 2025 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 19 11:09:24 2025 -0800
tree 5fcac37e7321ce76a7f7e3262baf50e5333e1622
parent a0302a696fd93780110243594042e903d95a0bca

Elements. Tweak nested getter/setter if(s) into switch.

Change-Id: Ie5136c282d4d9e670970284c5a0415791edbe28b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410860
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>

pkg/analyzer/lib/src/error/override_verifier.dart

diff --git a/pkg/analyzer/lib/src/error/override_verifier.dart b/pkg/analyzer/lib/src/error/override_verifier.dart
index 4cc0d73..3855632 100644
--- a/pkg/analyzer/lib/src/error/override_verifier.dart
+++ b/pkg/analyzer/lib/src/error/override_verifier.dart
@@ -61,23 +61,22 @@
   void visitMethodDeclaration(MethodDeclaration node) {
     var element = node.declaredFragment!.element;
     if (element.metadata2.hasOverride && !_isOverride(element)) {
-      if (element is MethodElement2) {
-        _errorReporter.atToken(
-          node.name,
-          WarningCode.OVERRIDE_ON_NON_OVERRIDING_METHOD,
-        );
-      } else if (element is PropertyAccessorElement2) {
-        if (element is GetterElement) {
+      switch (element) {
+        case MethodElement2():
+          _errorReporter.atToken(
+            node.name,
+            WarningCode.OVERRIDE_ON_NON_OVERRIDING_METHOD,
+          );
+        case GetterElement():
           _errorReporter.atToken(
             node.name,
             WarningCode.OVERRIDE_ON_NON_OVERRIDING_GETTER,
           );
-        } else {
+        case SetterElement():
           _errorReporter.atToken(
             node.name,
             WarningCode.OVERRIDE_ON_NON_OVERRIDING_SETTER,
           );
-        }
       }
     }
   }