commit 6d623f435d7ee19b655ee29985666c88ec1aba2c
author Derek Xu <derekx@google.com> Mon Feb 12 16:14:12 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Feb 12 16:14:12 2024 +0000
tree 2a3621dcf53250278adc1505d30e1ad08116cefa
parent 78dbc184b151440684faa525f63155c5230411ed

Make testee pause on exit in get_perfetto_cpu_samples_rpc_test

Since it currently seems like samples are being collected even after
`testeeDo` has finished, we can give this a try and see if it changes
anything.

Change-Id: Id6f95cfb457b033d17e5e32e3fe073a2f2b9a958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352080
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>

pkg/vm_service/test/get_perfetto_cpu_samples_rpc_test.dart

diff --git a/pkg/vm_service/test/get_perfetto_cpu_samples_rpc_test.dart b/pkg/vm_service/test/get_perfetto_cpu_samples_rpc_test.dart
index 591da60..1f3f808 100644
--- a/pkg/vm_service/test/get_perfetto_cpu_samples_rpc_test.dart
+++ b/pkg/vm_service/test/get_perfetto_cpu_samples_rpc_test.dart
@@ -8,6 +8,7 @@
 import 'package:vm_service/vm_service.dart' hide Timeline;
 import 'package:vm_service_protos/vm_service_protos.dart';
 
+import 'common/service_test_common.dart';
 import 'common/test_helper.dart';
 
 int fib(n) {
@@ -63,6 +64,7 @@
 }
 
 final tests = <IsolateTest>[
+  hasStoppedAtExit,
   (VmService service, IsolateRef isolateRef) async {
     final result = await service.getPerfettoCpuSamples(isolateRef.id!);
     expect(result.type, 'PerfettoCpuSamples');
@@ -115,6 +117,7 @@
       tests,
       'get_perfetto_cpu_samples_rpc_test.dart',
       testeeBefore: testeeDo,
+      pauseOnExit: true,
       extraArgs: [
         '--profiler=true',
         // Crank up the sampling rate to make sure we get samples.