commit | 6d4ebea83b7217b66112df7268ffc5fa6dd2fd36 | [log] [tgz] |
---|---|---|
author | Jens Johansen <jensj@google.com> | Mon Oct 28 11:11:48 2024 +0000 |
committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 28 11:11:48 2024 +0000 |
tree | 12233d3952c20d5b5cbcae9cd52455c5ed547f50 | |
parent | 01dddf659e03e2bd09b32f2291b3d3889c9dfd5a [diff] |
[kernel] Optimize reading of metadata further This optimization is based on the assumption (which at least holds true for the dill file extracted from the mentioned bug) that only very few nodes actually have metadata associated with it. For the test file, more than two million node-offsets is looked up, and only ~7.5 thousand nodes actually have metadata on it. What is done here is to assume that most often we ask offsets in order and that most often the answer is that there's no metadata (when we fall into this case we can return `false` quickly) and we can skip looking up the actual metadata. This furthermore - although not benchmark here - should make it (a lot) faster in the case where we have multiple subsections as we here only lookup in in one index. Only upon a `true` response from that we have to lookup in all subsections to find and read the actual metadata to associate. Reading the test file without metadata, taking an average of averages (average of 5 runs of the binary benchmarks output for "AstFromBinaryEager") takes: 374481.4 us. Before https://dart-review.googlesource.com/c/sdk/+/391761 reading the test file with metadata takes: 627120.68 us. This was about a quarter of a second, or 67+% slower. With https://dart-review.googlesource.com/c/sdk/+/391761 this number became: 441784.44 us. A reduction of ~185 ms, or almost 30%, making the tax of reading metadata "only" ~18%. With this CL this number goes to 398011.44 us. This is a further reduction of ~43 ms, or almost 10% (for a combined reduction of ~230 ms or 36+%). The tax of reading metadata is now ~6.3%. Bug: https://github.com/flutter/flutter/issues/156713 Change-Id: I20bbabecfc8976293fe897528d05fc2145e2a8c0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392021 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.