| commit | 6ce015e01e281f27bdbc451a654a84d30a21ac6b | [log] [tgz] |
|---|---|---|
| author | Konstantin Shcheglov <scheglov@google.com> | Mon Aug 25 11:26:20 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 25 11:26:20 2025 -0700 |
| tree | 08f9087ddf6bbbe01d183ded2186644d1f57bc7b | |
| parent | 9b3df8f2264d9ced1bdda9c60ece70efa8c984f7 [diff] |
Fine. Update PreferIsNotEmpty to use getGetter() instead of requesting all children.
Replace child enumeration with a targeted member lookup in the
`prefer_is_not_empty` rule. Instead of requesting all children to check
for `isNotEmpty`, the rule now calls `InterfaceElement.getGetter()` on
the declaring interface of `isEmpty`. This avoids recording an "opaque
API use" requirement and reduces unnecessary dependency tracking and
overhead.
Additionally, remove generic child-walking utilities from `ast.dart`
that were only used for this purpose.
Changes:
- In `prefer_is_not_empty.dart`, use
`InterfaceElement.getGetter('isNotEmpty')` instead of `getChildren`.
- Drop `getChildren`, `_visitChildren`, `ElementProcessor`, and the
visitor adapter from `ast.dart`, along with their imports.
- Remove the unused `../ast.dart` import from the rule and add the
precise `element.dart` import.
No functional changes to the lint’s intent: it still recommends
`isNotEmpty` for `Iterable` and `Map` types, but does so without walking
children, improving precision and performance of fine-grained tracking.
Found with https://dart-review.googlesource.com/c/sdk/+/446480
Change-Id: I1e0e9991aeba924b672d1216bed2669215ab20cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/446580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.