| commit | 6aeb8657810ab3dc55b2a60bcd4328be6490dd10 | [log] [tgz] |
|---|---|---|
| author | Martin Kustermann <kustermann@google.com> | Tue Jan 14 04:09:47 2025 -0800 |
| committer | Martin Kustermann <kustermann@google.com> | Tue Jan 14 04:09:47 2025 -0800 |
| tree | 52b243f3104bc6551725c6bcff11cef45b853872 | |
| parent | 45d5b483da0fd271cd09430c2375844d39426a2e [diff] |
[dart2wasm] Workaround bug in JavaScriptCore/WebKit in test runner The recent roll of JSC caused *many* failures on the dart2wasm-linux-optimized-jsc configuration. I believe this is due to a interpretation/optimization bug in JavaScriptCore/WebKit. => Filed https://bugs.webkit.org/show_bug.cgi?id=285902 It seems we can workaround this by passing `--useWasmIPInt=false` in the test runner for now. Issue https://github.com/dart-lang/sdk/issues/59899 Change-Id: Ie7ae7bf0a5654eb3362bc23934becd8162227992 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404104 Reviewed-by: Ömer Ağacan <omersa@google.com>
diff --git a/pkg/test_runner/lib/src/runtime_configuration.dart b/pkg/test_runner/lib/src/runtime_configuration.dart index 3f277af..d0c7643 100644 --- a/pkg/test_runner/lib/src/runtime_configuration.dart +++ b/pkg/test_runner/lib/src/runtime_configuration.dart
@@ -246,9 +246,13 @@ if (compiler != Compiler.dart2wasm) { throw 'No test runner setup for jsc + dart2js yet'; } + // TODO(https://bugs.webkit.org/show_bug.cgi?id=285902): Once the + // JavaScriptCore/WebKit bug is fixed we should be able to remove this + // again. + const jscBugWorkaround = '--shell-option=--useWasmIPInt=false'; return [ Dart2WasmCommandLineCommand(moniker, 'pkg/dart2wasm/tool/run_benchmark', - ['--jsc', ...arguments], environmentOverrides) + ['--jsc', jscBugWorkaround, ...arguments], environmentOverrides) ]; } }