)]}'
{
  "commit": "69f6378ed52dd118364c8e6b25a6ecbd8353ad07",
  "tree": "35d57cd25f5b34b2d0a639b7f4899e48f3f53e96",
  "parents": [
    "363da9038517e8895d69a39393c4023ba9a43ba1"
  ],
  "author": {
    "name": "Jens Johansen",
    "email": "jensj@google.com",
    "time": "Wed Apr 07 12:25:27 2021 +0000"
  },
  "committer": {
    "name": "commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Wed Apr 07 12:25:27 2021 +0000"
  },
  "message": "[CFE] Make unit_test_suites log better message when test starts to pass\n\nIn for instance https://dart-review.googlesource.com/c/sdk/+/193961/5\nwe had an instance of something good happening (a crashing-ish test\nthat started to pass) but where the author was told no (red bot) and\nnot given a path to make the bot happy (bad messaging).\n\nSpecifically tests failed and the best log one got was\n\n```\nTo re-run this test, run:\n    dart pkg/front_end/test/unit_test_suites.dart -p pkg/front_end/test/fasta/textual_outline/general/constants/js_semantics/issue45376\n```\n\nwhich isn\u0027t very helpful.\n\nIf running it locally a little more information is given via stdout,\nbut having to do that isn\u0027t great (and the little extra information\nstill wasn\u0027t great).\n\nThis CL updates the messaging to - hopefully - give a path to make the\nbot happy. The messaging will now - directly from the log\non the bot - be\n\n```\nFAILED: pkg/front_end/test/fasta/textual_outline/general/constants/js_semantics/issue45376: Pass\n\nTo re-run this test, run:\n\n   dart pkg/front_end/test/unit_test_suites.dart -p pkg/front_end/test/fasta/textual_outline/general/constants/js_semantics/issue45376\n\nThe test passed, but wasn\u0027t expected to. You should update the status file for this test.\nThere\u0027s a status entry looking something like\n\n  general/constants/js_semantics/issue45376: FormatterCrash\n\nwhich should be removed.\n\nThe status file is file:///[wherever]/sdk/pkg/front_end/testcases/textual_outline.status.\n```\n\nwhich\na) gives the extra information previously only available via stdout when\n   running locally (the first line).\nb) Gives an explanation as to why it failed\n   (\"The test passed, but wasn\u0027t expected to.\").\nc) A path to make the bot green (\"You should update the status file for\n   this test. [...] should be removed\").\n\nHopefully this will make it easier to deal with in the future when\nsomething good happens.\n\nChange-Id: I838699abce580334c956d8b4753884fd600802ae\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/194242\nCommit-Queue: Jens Johansen \u003cjensj@google.com\u003e\nReviewed-by: Johnni Winther \u003cjohnniwinther@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c67f5b3e6a9932f2897b8d07e9bd434f01c64fde",
      "old_mode": 33188,
      "old_path": "pkg/front_end/test/unit_test_suites_impl.dart",
      "new_id": "cdead851fa39d7c1ae22d978a7b648ee4f8f8124",
      "new_mode": 33188,
      "new_path": "pkg/front_end/test/unit_test_suites_impl.dart"
    }
  ]
}