| commit | 671f271f5825d50aa3a9460dd1f478544ed4ec85 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Thu Apr 04 10:41:15 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 04 10:41:15 2024 +0000 |
| tree | b9138430ed4982f27a7735f88e6ecfa292366a39 | |
| parent | 1074cda324ca4efc1da554deec3c2e8f61f175d6 [diff] |
[vm/compiler] More consolidation of Store assembler methods. Add OperandSize arguments to the non-compressed Store methods so that the compressed Store methods can be implemented as calls to the corresponding non-compressed method using kObjectBytes. This makes it so that all compressed Store methods are now non-virtual. Add a scratch register argument to all Store methods that involve a write barrier that defaults to TMP. Originally only the IA32 implementation took a scratch register, with the others using TMP or TMP2 internally. Since all architectures can represent a register/offset pair as an Address without losing information, make all the offset-based load and store methods have an implementation that creates an Address or FieldAddress and calls the corresponding address-based store method. This makes all the offset-based load and store methods non-virtual. After this, most of the Store methods are non-virtual, with only the base methods used to implement them as virtual: * Store * StoreRelease * StoreObjectIntoObjectNoBarrier * StoreBarrier * ArrayStoreBarrier * VerifyStoreNeedsNoWriteBarrier (for DEBUG use only) The Load methods can't be consolidated quite so much, as the base methods for handling non-Smi compressed pointers must be defined per-architecture, as each compressed pointer architecture handles adding the upper bits for the heap separately. Have LoadFieldInstr::EmitNativeCode use Assembler::LoadToSlot when the result location is a single integer register and StoreFieldInstr::EmitNativeCode use Assembler::StoreToSlot and Assembler::StoreToSlotNoBarrier when the value location is a single integer register to avoid code duplication between those methods. Handle both compressed and uncompressed Smi fields in LoadFromSlot. TEST=ci (refactoring) Cq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-x64-try,vm-win-release-ia32-try Change-Id: I60cc03776af220ed87918664bb4b9abafff2788a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360641 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.