| commit | 66bcc1e08b865ef172ffab37c1a9ec91cdd9253b | [log] [tgz] |
|---|---|---|
| author | Vyacheslav Egorov <vegorov@google.com> | Thu Aug 14 05:24:21 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 14 05:24:21 2025 -0700 |
| tree | 4016351b68fd28da640183eee0de0371ce230355 | |
| parent | 67d39caa81551c009769febded1c2ac1a49a792c [diff] |
[dartdev] Fix race in DartDev::RunDartDev It was checking DartDev::result_ was set to determine if dartdev is done, however the intent of the code is to only continue once we receive DartDev_Result_Exit from dartdev (based on the fact that we only Notify in ExitResultCallback). This code was incorrect if we encounter a spurios wakeup: we might reach RunExecResultCallback but only execute it partially i.e. set result_ to DartDev_Result_RunExec but only partially initialize argv_ and argc_, and not yet initialize script_name_. However at this point we might spuriously wakeup from our Wait in RunDartDev and think that we can continue - which means we will hit a crash once we try to use partially initialized information for Process::Exec which would cause us to crash. The bug was discovered based on stack traces provided by Elliott Brooks (elliottbrooks) which occur on Dev Tools CI. TEST=too hard to reliably test this Change-Id: Ied9cace6bec9505b51ac0142795708466d166f28 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445180 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.