| commit | 0170b8d529a60a18c175dfe187896388621f5768 | [log] [tgz] |
|---|---|---|
| author | Aart Bik <ajcbik@google.com> | Wed Oct 24 22:49:10 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Oct 24 22:49:10 2018 +0000 |
| tree | f8c42b1169d3ceb0cd4f7fdbc9669d4180dea9a8 | |
| parent | 9aff9309248558dfa057cadc8f1517895fa8d7bc [diff] |
Revert "[vm/compiler] Use loop framework for AOT inline heuristics" This reverts commit daae20d32e828fad298d7d12327aa30ac2927a47. Reason for revert: The kernel-precomp bots are seeing this error: ../../runtime/vm/object.h: 3134: error: Handle check failed: saw 2249186640 expected Function Not sure what that is yet, but reverting to get bots green again while I investigate. Original change's description: > [vm/compiler] Use loop framework for AOT inline heuristics > > Rationale: > Without proper execution counters, the inline AOT inliner > marks every call site "cold", effectively disabling inlining > altogether. This change introduces loop-based static heuristic > that assumes statements nested inside loops are executed more > frequently. This results in more inlining. > > Note: > Conservative version is used for now which yields > more performance without increasing code size too much. > There is still a lot of performance left at the table > which we could exploit if we fine tune heuristics > regarding code size. > > Bug: > https://github.com/dart-lang/sdk/issues/34473 > https://github.com/dart-lang/sdk/issues/32167 > > > Change-Id: I86ba60f93bdab363cd22ab6bdbcf6688f2042fea > Reviewed-on: https://dart-review.googlesource.com/c/81187 > Commit-Queue: Aart Bik <ajcbik@google.com> > Reviewed-by: Alexander Markov <alexmarkov@google.com> TBR=vegorov@google.com,alexmarkov@google.com,ajcbik@google.com Change-Id: If5ca82966966ebef4ec0b4e921515d23f6bd492b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/81335 Reviewed-by: Aart Bik <ajcbik@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.