| commit | 64a169ec7eafab6c40d7a72a491f5f91d74262d3 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Thu Apr 21 09:12:47 2022 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Apr 21 09:12:47 2022 +0000 |
| tree | 2f5a720679cef5267410f32b181c2376a87e4c75 | |
| parent | 3aa8f2519b6bf68c6ca3ccd668da9c921ac2f55a [diff] |
[CFE] Avoid crash with experimental invalidation when same file is imported with both package and file uri If importing the same file both by package-uri and file-uri it becomes two different libraries in the compiler. They both have the same file uri though. When invalidating such a file by file uri they will both be invalidated. When having experimental invalidation enabled it will - for each of those invalidated libraries - get the source, compare it to the current on-disk source, and - if the outline hasn't changed - remove the old source to avoid having something wrong in memory. When trying to process the second version of the file the old source has been removed and we thus will crash if using a bang on the output from the uriToSource lookup. This CL avoids the crash by postponing the removal of the old source until we're sure we'll return successfully. This is also more correct in general as we might otherwise remove sources where we're (for later reasons) going to bail out. Change-Id: If5d767764a958b2dbb09cc011745e13e572038a5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241745 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.