| commit | 62e3c47e45bb3ef0ca3338f3b25e0c4ecce10a50 | [log] [tgz] |
|---|---|---|
| author | Mayank Patke <fishythefish@google.com> | Fri Mar 17 19:44:34 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 17 19:44:34 2023 +0000 |
| tree | bc5d64732fd56247b8aa836680fe84c6ea1390b1 | |
| parent | 6f45c8534ee65e05f8aea53a80339d0a0a7056e4 [diff] |
[dart2js] Don't rely on `== null` promoting to Null in rti.dart. Although the true branch of `x != null` and the false branch of `x == null` promote `x` to non-nullable, the opposing branches do not promote `x` to `Null` in the current flow analysis spec, which applies to the CFE. When switching from the dart2js static type computation to the CFE static type computation, attempting to use `x` in these branches may generate an unintended type check, which can overflow the stack if this occurs in code responsible for performing type checks. The fix is fairly straightforward - we can simply use an unchecked cast (via `JS`) instead. See https://github.com/dart-lang/language/issues/1505 for discussion on why the expected promotion does not (yet) occur. Change-Id: Ia9cca4e1aa8e9c67b42c60189f0d3811afb61360 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289061 Reviewed-by: Stephen Adams <sra@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.