| commit | 62a67ba5bca0b17dc53a14061c3f9f4bc5e2b607 | [log] [tgz] |
|---|---|---|
| author | Stephen Adams <sra@google.com> | Tue Apr 18 20:39:39 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 18 20:39:39 2023 +0000 |
| tree | af89ba030fc7634c23ba6ac19cb376fd5b4f5d52 | |
| parent | 000655e4d374bb1a7e7a335160cfa116e6968cff [diff] |
[dart2js][js_runtime] Use Array.isArray more consistently The main reason is to do this change is to avoid inconsistencies in what is considered to be a `JSArray`. Using `Array.isArray` allows js-interop where the JavaScript code subclasses `Array`. dart2js-production results: ArrayLoop.pseudopoly.hoisted1-indexing -50.20% ArrayLoop.pseudopoly.indexing -35.18% Iteration.concat.manual 11.69% ListCopy.List.int.unmodifiable.2 12.03% ListCopy.for.int.2 12.58% ListCopy.spread.int.2 13.57% ListCopy.toList.fixed.100 16.06% ListCopy.List.of.fixed.100 16.96% ListCopy.toList.100 17.28% ListCopy.spread.int.cast.2 18.45% ObjectHash.hash.5 19.62% TypedDataPoly.A_UVx5.view.2 21.12% ObjectHash.manual.5 21.70% ListCopy.spread.int.map.2 21.96% ListCopy.spread.int.cast.100 22.12% TypedDataPoly.A_UVx5.view.100 23.04% ListCopy.spread.int.map.100 25.26% ListCopy.List.of.100 27.88% ImagingGaussianBlurOnce 29.67% MegaEquality 37.90% An investigation of the two regressions shows that they benefit from a micro-benchmarking effect. The previous code was monomorphic at the property access in `receiver.constructor == Array`. If this is forced to be polymorphic, the baseline is quite a bit worse, leading to an improvement in line with some of the other benchmarks. Change-Id: I5c265b1d7408fbd41da9c6fa17472bf648000c8d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287140 Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Stephen Adams <sra@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.