| commit | b4a72556843b20b2a73720761457bd9e600231c0 | [log] [tgz] |
|---|---|---|
| author | Konstantin Shcheglov <scheglov@google.com> | Tue Dec 18 20:43:52 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Dec 18 20:43:52 2018 +0000 |
| tree | b92c0a40bd3393a4616bd5603ebd244f0b444b47 | |
| parent | f8a680e5116493f8795c148a52dbecf8a84e4536 [diff] |
Issue 35438. When no linked library, fill also _resynthesizedUnits when creating a synthetic library. There are no linked library because LibraryContext does not add it if FileState.exists is false. I'm not quite satisfied that we do this, because everywhere else we pretend that any file exists, but possibly with empty content. However we use absence of the linked library as a signal that `LibraryElement.isSynthetic` should be set. So, we would need to signal not existing library to resynthesizer in some other way, or make changes in places where we use `isSynthetic` to decide whether to report errors. R=brianwilkerson@google.com, paulberry@google.com Bug: https://github.com/dart-lang/sdk/issues/35438 Change-Id: I39ad7d173b85a2e0bc7333bb7bee9fad709e0dea Reviewed-on: https://dart-review.googlesource.com/c/87603 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.