)]}' { "commit": "6134ac86481f01ed865beb297363bb26ed61aed6", "tree": "276af6472e852b606b2fa94dce635a7087a8125e", "parents": [ "4e49d19bd6c4f46acbdba59b008b7c03c1814a12" ], "author": { "name": "Régis Crelier", "email": "regis@google.com", "time": "Tue Oct 23 19:04:18 2018 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Oct 23 19:04:18 2018 +0000" }, "message": "Revert \"[VM runtime] Support Smi instances in type test cache.\"\n\nThis reverts commit 6ba3e55eccf343357549f0643b2cb75ccdb53d9b.\n\nReason for revert: unhappy kernel-precomp bots\n\nOriginal change\u0027s description:\n\u003e [VM runtime] Support Smi instances in type test cache.\n\u003e \n\u003e This adds SubtypeTestCache-based optimizations for type tests against\n\u003e * dst_type \u003d FutureOr\u003cT\u003e (when T\u003dint/num)\n\u003e * dst_type \u003d T (when T \u003d FutureOr\u003cint/num\u003e)\n\u003e \n\u003e Remove dangerous LoadClass pseudo assembler instruction (does not work for Smi).\n\u003e Handle instantiated void in type tests (along with dynamic and Object).\n\u003e \n\u003e Change-Id: I0df0fc72ff173b9464d16cc971969132b055a429\n\u003e Reviewed-on: https://dart-review.googlesource.com/c/81182\n\u003e Commit-Queue: Régis Crelier \u003cregis@google.com\u003e\n\u003e Reviewed-by: Martin Kustermann \u003ckustermann@google.com\u003e\n\nTBR\u003dkustermann@google.com,alexmarkov@google.com,regis@google.com\n\nChange-Id: I73be5fc068cd24e0a13ba0872a99a24ab5a8eeca\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://dart-review.googlesource.com/c/81284\nReviewed-by: Régis Crelier \u003cregis@google.com\u003e\nCommit-Queue: Régis Crelier \u003cregis@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "e35c3c1f24b43c6fa9932b5e593b6077ddcea1e1", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_arm.cc", "new_id": "1f56574a47e62be0ce81f1680bbbd1abd2d873aa", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_arm.cc" }, { "type": "modify", "old_id": "93da8c4e3bedcc7ee1873c4108b96428063451b0", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_arm.h", "new_id": "e78943db958fe6b8aeaf21e6dd3073091ad7eb1d", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_arm.h" }, { "type": "modify", "old_id": "c258d9a57d69a0647cbf5e45992a3f8d6543c7eb", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_arm64.cc", "new_id": "cdd45c870a4e9b51a539f466540944f94d1046ce", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_arm64.cc" }, { "type": "modify", "old_id": "7807f87ac4ba5118835605a7d2bb8198d103f5db", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_arm64.h", "new_id": "785b0ac02fe1364997226b103dbb8411e2978ada", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_arm64.h" }, { "type": "modify", "old_id": "e2074e5c52d33ad0fe46ef3c665b092d9115ef60", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_ia32.cc", "new_id": "1f528e1803444f439b30615cc28082917a53801e", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_ia32.cc" }, { "type": "modify", "old_id": "cb75d28c26c3e976be7aab1f7116efa0736cb2aa", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_ia32.h", "new_id": "c3b8492f56ce65410234163ec66a4a758a7e33bc", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_ia32.h" }, { "type": "modify", "old_id": "c91098b9b3b7cf40eccce62b39e770c69526444f", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_x64.cc", "new_id": "d3df2c37019d51459b44a75ade3a08c5498a33b0", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_x64.cc" }, { "type": "modify", "old_id": "6090c766d5b413368b7a25ac53ca0dc33ee12303", "old_mode": 33188, "old_path": "runtime/vm/compiler/assembler/assembler_x64.h", "new_id": "70f7d9e2784af3a32696692e7a09f00ac049b036", "new_mode": 33188, "new_path": "runtime/vm/compiler/assembler/assembler_x64.h" }, { "type": "modify", "old_id": "729d9ffda7909eefe0118ef4afb2dcb7654c7eab", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/flow_graph_compiler_arm.cc", "new_id": "b6a070fe1a7204b624eb4b2cae9089ba1d7cca00", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/flow_graph_compiler_arm.cc" }, { "type": "modify", "old_id": "4812ac496591b774fd5e71a6e2d953483499d165", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/flow_graph_compiler_arm64.cc", "new_id": "eb23398a0e55bbd695eb5b84b1ce148629b06bf8", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/flow_graph_compiler_arm64.cc" }, { "type": "modify", "old_id": "f6dc95a399a2b86ec0d5c3f5d44ff033a384510f", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/flow_graph_compiler_ia32.cc", "new_id": "d8de557a05c0c9eea6d0efd13348ec37bd807800", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/flow_graph_compiler_ia32.cc" }, { "type": "modify", "old_id": "2471b4e23b9eee437064ba425b0436d67dc2fa65", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/flow_graph_compiler_x64.cc", "new_id": "d3e58d8ea3b723d25def3888f9ef8c73fd9b2540", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/flow_graph_compiler_x64.cc" }, { "type": "modify", "old_id": "5994aed216714a5e92a147be437508cc1d2cbae2", "old_mode": 33188, "old_path": "runtime/vm/runtime_entry.cc", "new_id": "ad00ea5842c009870a3d32d35f766b83304bd86d", "new_mode": 33188, "new_path": "runtime/vm/runtime_entry.cc" }, { "type": "modify", "old_id": "2ddd1dc2f63e1df1e75385ca376a4f8a38bb01cd", "old_mode": 33188, "old_path": "runtime/vm/stub_code_arm.cc", "new_id": "879101321fa90d916c2599d4adda5a99b31bf7ca", "new_mode": 33188, "new_path": "runtime/vm/stub_code_arm.cc" }, { "type": "modify", "old_id": "fc8727942c581092926be17061f003bf007827b9", "old_mode": 33188, "old_path": "runtime/vm/stub_code_arm64.cc", "new_id": "8aa821379d84ce7efb6edad51bc217688ffa6a21", "new_mode": 33188, "new_path": "runtime/vm/stub_code_arm64.cc" }, { "type": "modify", "old_id": "d609e2a676c09e525b076f3572bb8ea443ccb7c9", "old_mode": 33188, "old_path": "runtime/vm/stub_code_ia32.cc", "new_id": "4535bad30b4df0bbc3dafa3f86ff59c42d8339c1", "new_mode": 33188, "new_path": "runtime/vm/stub_code_ia32.cc" }, { "type": "modify", "old_id": "295d7ce4277230855288bbd2cd56ebcdf1fe827c", "old_mode": 33188, "old_path": "runtime/vm/stub_code_x64.cc", "new_id": "c8f42180b7c314c36f260b3721b9577b36911bf9", "new_mode": 33188, "new_path": "runtime/vm/stub_code_x64.cc" } ] }