tree 625ed7ec645e9badaad49cc167a418ea3455c272
parent 2b246127f7f9a1773ed22e1c712df72137d9fc67
author Paul Berry <paulberry@google.com> 1601407638 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1601407638 +0000

Fix handling of for-elements with unparenthesized bodies.

The CFE defers the final build of the body of a for-element until
after building the rest of the body.  This caused a bug: if the body
was an assignment expression, flow analysis was not picking up on the
fact that the assignment was inside the loop.

Fixed by introducing a mechanism that allows the CFE to temporarily
pop the innermost structure on the AssignedVariables stack and then
push it again.

Change-Id: I11d526302934e9283807124ebd4a23e9d3e5ec66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164980
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>