| commit | 5e48ccb808a392a16a0d35edf3c2dbd661dcc660 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Mon Feb 11 09:58:40 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Mon Feb 11 09:58:40 2019 +0000 |
| tree | b12d28e4e69c43373b14940e8f35d1395fa9a574 | |
| parent | a5c53b03cd4a2bb5097077643279a7a7188dabfb [diff] |
Give more context when initializing from dill fails Previously, if failing when trying to load from a dill it would say something like Warning: Tried to initialize from a previous compilation (build/app.dill), but couldn't. Error message was 'NoSuchMethodError: The method 'getReference' was called on null. Receiver: null Tried calling: getReference()'. This might be a bug. The Dart team would greatly appreciate if you would take a moment to report this problem at http://dartbug.com/new. Which really doesn't give us a lot to go on. This CL changes that to also give us a little go to on, and report something like Warning: Tried to initialize from a previous compilation (org-dartlang-test:///initializeFrom.dill), but couldn't. Error message was 'NoSuchMethodError: The method 'getReference' was called on null. Receiver: null Tried calling: getReference()'. Stacktrace included '#0 Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:50:5) #1 BinaryBuilder.readLibraryReference (package:kernel/binary/ast_from_binary.dart:692:9) #2 BinaryBuilder.readLibraryDependency (package:kernel/binary/ast_from_binary.dart:837:25) #3 BinaryBuilder._readLibraryDependencies (package:kernel/binary/ast_from_binary.dart:829:33) #4 BinaryBuilder.readLibrary (package:kernel/binary/ast_from_binary.dart:803:5) #5 BinaryBuilder._readOneComponent (package:kernel/binary/ast_from_binary.dart:634:7) #6 BinaryBuilder.readComponent (package:kernel/binary/ast_from_binary.dart:441:7) #7 IncrementalCompiler.initializeFromDill (package:front_end/src/fasta/incremental_compiler.dart:395:14) <asynchronous suspension> #8 IncrementalCompiler.computeDelta.<anonymous closure> (package:front_end/src/fasta/incremental_compiler.dart:126:23) <asynchronous suspension> #9 CompilerContext.runInContext.<anonymous closure>.<anonymous closure> (package:front_end/src/fasta/compiler_context.dart:120:46) #10 new Future.sync (dart:async/future.dart:224:31) #11 CompilerContext.runInContext.<anonymous closure> (package:front_end/src/fasta/compiler_context.dart:120:19) #12 _rootRun (dart:async/zone.dart:1124:13) #13 _CustomZone.run (dart:async/zone.dart:1021:19) #14 _runZoned (dart:async/zone.dart:1516:10) #15 runZoned (dart:async/zone.dart:1463:12) #16 CompilerContext.runInContext (package:front_end/src/fasta/compiler_context.dart:119:12) #17 IncrementalCompiler.computeDelta (package:front_end/src/fasta/incremental_compiler.dart:108:20) <asynchronous suspension> #18 initializedCompile (file:///usr/local/google/home/jensj/code/dart-sdk/sdk/pkg/front_end/test/incremental_load_from_dill_test.dart:397:51) <asynchronous suspension> #19 basicTest (file:///usr/local/google/home/jensj/code/dart-sdk/sdk/pkg/front_end/test/incremental_load_from_dill_test.dart:167:34) <asynchronous suspension> #20 RunCompilations.run (file:///usr/local/google/home/jensj/code/dart-sdk/sdk/pkg/front_end/test/incremental_load_from_dill_test.dart:101:15) <asynchronous suspension> #21 ChainContext.run.doStep.<anonymous closure> (package:testing/src/chain.dart:180:33) <asynchronous suspension> #22 new Future.<anonymous closure> (dart:async/future.dart:176:37) #23 _rootRun (dart:async/zone.dart:1120:38) #24 _CustomZone.run (dart:async/zone.dart:1021:19) #25 _CustomZone.runGuarded (dart:async/zone.dart:923:7) #26 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23) #27 _rootRun (dart:async/zone.dart:1124:13) #28 _CustomZone.run (dart:async/zone.dart:1021:19) #29 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23) #30 Timer._createTimer.<anonymous closure> (dart:async/runtime/libtimer_patch.dart:21:15) #31 _Timer._runTimers (dart:isolate/runtime/libtimer_impl.dart:382:19) #32 _Timer._handleMessage (dart:isolate/runtime/libtimer_impl.dart:416:5) #33 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12) '. This might be a bug. The Dart team would greatly appreciate if you would take a moment to report this problem at http://dartbug.com/new. which will hopefully allow us to actually debug any such reports. Change-Id: I13bdd4f96c1e4bb2dcce91e533442b48c87c9e0c Reviewed-on: https://dart-review.googlesource.com/c/85348 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Peter von der Ahé <ahe@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.