remove experiment tests
Fixes: https://github.com/dart-lang/linter/issues/4734
Change-Id: If39807f0a97641d33b879fab7d5c5fc408e69847
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323447
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/linter/test/experiments_test.dart b/pkg/linter/test/experiments_test.dart
deleted file mode 100644
index e8fe7ae..0000000
--- a/pkg/linter/test/experiments_test.dart
+++ /dev/null
@@ -1,37 +0,0 @@
-// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:io';
-
-import 'package:path/path.dart' as p;
-import 'package:test/test.dart';
-
-import '../test_data/rules/experiments/experiments.dart';
-import 'rule_test.dart';
-import 'test_constants.dart';
-
-void main() {
- group('experiments', () {
- registerLintRuleExperiments();
-
- for (var entry
- in Directory(p.join(ruleTestDataDir, 'experiments')).listSync()) {
- if (entry is! Directory) continue;
-
- group(p.basename(entry.path), () {
- var analysisOptionsFile =
- File(p.join(entry.path, 'analysis_options.yaml'));
- var analysisOptions = analysisOptionsFile.readAsStringSync();
- var ruleTestDir = Directory(p.join(entry.path, 'rules'));
- for (var test in ruleTestDir.listSync()) {
- if (test is! File) continue;
- var testFile = test;
- var ruleName = p.basenameWithoutExtension(test.path);
- if (ruleName.startsWith('.')) continue;
- testRule(ruleName, testFile, analysisOptions: analysisOptions);
- }
- });
- }
- });
-}
diff --git a/pkg/linter/test/integration_test.dart b/pkg/linter/test/integration_test.dart
index 77803fd..f1e26e5 100644
--- a/pkg/linter/test/integration_test.dart
+++ b/pkg/linter/test/integration_test.dart
@@ -13,7 +13,6 @@
import 'package:test/test.dart';
import 'package:yaml/yaml.dart';
-import '../test_data/rules/experiments/experiments.dart';
import 'integration/avoid_web_libraries_in_flutter.dart'
as avoid_web_libraries_in_flutter;
import 'integration/close_sinks.dart' as close_sinks;
@@ -75,10 +74,7 @@
registerLintRules();
var registered = Analyzer.facade.registeredRules
- .where((r) =>
- !r.state.isDeprecated &&
- !r.state.isRemoved &&
- !experiments.contains(r))
+ .where((r) => !r.state.isDeprecated && !r.state.isRemoved)
.map((r) => r.name);
for (var l in configuredLints) {
diff --git a/pkg/linter/test/rule_test.dart b/pkg/linter/test/rule_test.dart
index 468c445..d64fada 100644
--- a/pkg/linter/test/rule_test.dart
+++ b/pkg/linter/test/rule_test.dart
@@ -26,7 +26,6 @@
import 'package:path/path.dart' as p;
import 'package:test/test.dart';
-import 'experiments_test.dart' as experiment_tests;
import 'test_constants.dart';
import 'util/annotation_matcher.dart';
import 'util/test_utils.dart';
@@ -35,7 +34,6 @@
group('rule tests', () {
setUp(setUpSharedTestEnvironment);
defineRuleTests();
- experiment_tests.main();
defineRuleUnitTests();
});
}
diff --git a/pkg/linter/test_data/rules/experiments/experiments.dart b/pkg/linter/test_data/rules/experiments/experiments.dart
deleted file mode 100644
index 081d8a5..0000000
--- a/pkg/linter/test_data/rules/experiments/experiments.dart
+++ /dev/null
@@ -1,30 +0,0 @@
-// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'package:linter/src/analyzer.dart';
-import 'package:linter/src/rules/always_declare_return_types.dart';
-import 'package:linter/src/rules/avoid_returning_this.dart';
-import 'package:linter/src/rules/avoid_positional_boolean_parameters.dart';
-import 'package:linter/src/rules/camel_case_extensions.dart';
-import 'package:linter/src/rules/prefer_constructors_over_static_methods.dart';
-import 'package:linter/src/rules/public_member_api_docs.dart';
-import 'package:linter/src/rules/slash_for_doc_comments.dart';
-import 'package:linter/src/rules/type_annotate_public_apis.dart';
-import 'package:linter/src/rules/use_setters_to_change_properties.dart';
-
-final experiments = <LintRule>[
- AlwaysDeclareReturnTypes(),
- AvoidPositionalBooleanParameters(),
- AvoidReturningThis(),
- CamelCaseExtensions(),
- PreferConstructorsInsteadOfStaticMethods(),
- PublicMemberApiDocs(),
- SlashForDocComments(),
- TypeAnnotatePublicApis(),
- UseSettersToChangeAProperty(),
-];
-
-void registerLintRuleExperiments() {
- experiments.forEach(Analyzer.facade.register);
-}
diff --git a/pkg/linter/test_data/rules/experiments/nnbd/analysis_options.yaml b/pkg/linter/test_data/rules/experiments/nnbd/analysis_options.yaml
deleted file mode 100644
index 4163582..0000000
--- a/pkg/linter/test_data/rules/experiments/nnbd/analysis_options.yaml
+++ /dev/null
@@ -1,3 +0,0 @@
-analyzer:
- enable-experiment:
- - non-nullable
