| commit | 579cbd80bd4979e0f10279d53835b23c27214d50 | [log] [tgz] |
|---|---|---|
| author | Martin Kamleithner <martin.kamleithner@gmail.com> | Fri Apr 04 10:26:40 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 04 10:26:40 2025 -0700 |
| tree | dd6d1c880e68e3375969e0fbfc89f443b21a49ea | |
| parent | dca5a937c1bc4340bebe457b5a6bf7ea2a5a3dcd [diff] |
Add missing visit() methods in ExitDetectors for pattern assignments
I have run into a crash in the Analyzer when running `dart fix` on a
Flutter project.
minimal repro:
import 'package:flutter/widgets.dart';
void patternIssue(BuildContext context) {
if (true) {
final (string: string) = (string: "");
}
context.toString();
}
If one runs `dart fix --dry-run` on this file, it will throw
Computing fixes in exit_detector_bug (dry run)...
An unexpected error was encountered by the Analysis Server.
Please file an issue at https://github.com/dart-
lang/sdk/issues/new/choose with the following details:
Internal error: Exception while using a UseBuildContextSynchronously
to visit a MethodInvocationImpl in ExpressionStatementImpl in
BlockImpl in BlockFunctionBodyImpl in FunctionExpressionImpl in
FunctionDeclarationImpl in CompilationUnitImpl
Bad state: Missing a visit method for a node of type
PatternVariableDeclarationStatementImpl
I tracked this down to ExitDetector not having implementations for
various visit methods related to patterns.
I added these implementations and added a test.
R=cstefantsova@google.com
Change-Id: I7c090b261e9ceb53d9b50d0a931bffcec772f8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Martin Kamleithner <martin.kamleithner@gmail.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.