)]}' { "commit": "5b7968346df79b7ce3fb179998d3745e51c496e0", "tree": "0105f1a017c190874df02f7d6be648e8b9454fdb", "parents": [ "4389cf7bba5312c9be0e53e994674c412fdc13ee" ], "author": { "name": "Johnni Winther", "email": "johnniwinther@google.com", "time": "Fri Sep 24 12:01:08 2021 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Sep 24 12:01:08 2021 +0000" }, "message": "[kernel] Add Field.fieldReference\n\nThis adds a third reference to Field declaration, so that we know have\nthree references, one for each use case:\n\n1) fieldReference used for initialization; in FieldInitializer and as\n the key in the InstanceConstant.fieldValues map.\n2) getterReference used for reading; in InstanceGet, StaticGet and\n SuperPropertyGet\n3) setterReference used for writing; in InstanceSet, StaticSet and\n SuperPropertySet\n\nTEST\u003dexisting\n\nChange-Id: I223f130e808e7f19a831c1fe5e3a4725d1bcdc3b\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/203770\nCommit-Queue: Johnni Winther \u003cjohnniwinther@google.com\u003e\nReviewed-by: Jens Johansen \u003cjensj@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "80799f3666d8076cc124625d415cd6169a1d37ca", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/kernel/transformations/clone_mixin_methods_with_super.dart", "new_id": "abefe2dea569e4538a1c267209367622edadbbbf", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/kernel/transformations/clone_mixin_methods_with_super.dart" }, { "type": "modify", "old_id": "3c3b87c945ae6686885a0b9788bf57a62af23fbe", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/builder/enum_builder.dart", "new_id": "5fff7391485edd9634c4b73fb0d39ed24b8959fe", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/builder/enum_builder.dart" }, { "type": "modify", "old_id": "ca2aa439fe9266e9007f9afa5d5a1187b5fa83a1", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/builder/field_builder.dart", "new_id": "df0d819a055bb43773f62f554c88d7bbb4536b96", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/builder/field_builder.dart" }, { "type": "modify", "old_id": "d012efa96fe6d90caaf22bd7153a6a66f905308e", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart", "new_id": "13f9eadeafcf169e3adc07cc52094079a15bea57", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart" }, { "type": "modify", "old_id": "57d4f7c4a899ac09f4d2b9da1e4bbd624ea073e9", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/kernel/type_labeler.dart", "new_id": "4ebcb03533338b2e7d4037430ad42493a81865e6", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/kernel/type_labeler.dart" }, { "type": "modify", "old_id": "b1ed2fa2ae954bb7f5d7ed833f2846768659f72d", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/source/source_class_builder.dart", "new_id": "448fe6729bd337fcf8205590aae5bf26910ac397", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/source/source_class_builder.dart" }, { "type": "modify", "old_id": "763ce00d80593b44ad3e2ce9fca04fc55201380a", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/source/source_extension_builder.dart", "new_id": "4760e5818a2a03dea2ee781a923051f1b72df4e3", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/source/source_extension_builder.dart" }, { "type": "modify", "old_id": "1c83138e614c56a411c9336f5eb202711e8936fc", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/source/source_library_builder.dart", "new_id": "480fb3aca2ea2e930ffb79bbe005ed0cb777ecbb", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/source/source_library_builder.dart" }, { "type": "modify", "old_id": "4b4f06053cb3709ee318fe5740798bf353bf20a7", "old_mode": 33188, "old_path": "pkg/front_end/test/incremental_suite.dart", "new_id": "30745c34fe5104a2b5353ea0a6116dacd69653fb", "new_mode": 33188, "new_path": "pkg/front_end/test/incremental_suite.dart" }, { "type": "modify", "old_id": "8681a9fe33f74bab5b845f96997621a66e87c793", "old_mode": 33188, "old_path": "pkg/front_end/test/type_labeler_test.dart", "new_id": "ec09139a1f2a3b2ef8fa4dab916f2be74e8b8064", "new_mode": 33188, "new_path": "pkg/front_end/test/type_labeler_test.dart" }, { "type": "modify", "old_id": "7ea5230392c95ad3ca1a66572b4a96fde9b7c393", "old_mode": 33188, "old_path": "pkg/front_end/tool/ast_model.dart", "new_id": "834aa12562b26473c0827b6f9b7b458748e46fd2", "new_mode": 33188, "new_path": "pkg/front_end/tool/ast_model.dart" }, { "type": "modify", "old_id": "1a0a3a2887cdc683c39cdc6cfd7614b05b4ae9b6", "old_mode": 33188, "old_path": "pkg/kernel/binary.md", "new_id": "8c4fccfcf5ad883b20b2b672694d863a9765e3e2", "new_mode": 33188, "new_path": "pkg/kernel/binary.md" }, { "type": "modify", "old_id": "14dabffe1a3e8cb786234291cf5525cbb041e134", "old_mode": 33188, "old_path": "pkg/kernel/lib/ast.dart", "new_id": "ee30a76e4e4291294ec2f598a27c3002d4745140", "new_mode": 33188, "new_path": "pkg/kernel/lib/ast.dart" }, { "type": "modify", "old_id": "1423d0dd4bf6d0ceb2ed6317eb8d728705f52ef2", "old_mode": 33188, "old_path": "pkg/kernel/lib/binary/ast_from_binary.dart", "new_id": "12c33df60c9fae01a096c4f35fa3a1a3aba47835", "new_mode": 33188, "new_path": "pkg/kernel/lib/binary/ast_from_binary.dart" }, { "type": "modify", "old_id": "6cb1bd768202846707a3cb72ee41bd0a209e35f4", "old_mode": 33188, "old_path": "pkg/kernel/lib/binary/ast_to_binary.dart", "new_id": "a6d04bda8664e9f6d2c2e4d732c01aa23e9ba08d", "new_mode": 33188, "new_path": "pkg/kernel/lib/binary/ast_to_binary.dart" }, { "type": "modify", "old_id": "b628f87f8b60afffa27d75a71e5fb4a84ee9f89a", "old_mode": 33188, "old_path": "pkg/kernel/lib/binary/tag.dart", "new_id": "8fb7add83542d52c8cf29e7bcaa6eca54611383f", "new_mode": 33188, "new_path": "pkg/kernel/lib/binary/tag.dart" }, { "type": "modify", "old_id": "bd151c10d873bd39ce137967cb2821effdfb7722", "old_mode": 33188, "old_path": "pkg/kernel/lib/canonical_name.dart", "new_id": "651c2d61d25459f07bacff3820ffb2d1f16a0181", "new_mode": 33188, "new_path": "pkg/kernel/lib/canonical_name.dart" }, { "type": "modify", "old_id": "fec13cc4c4b8024cd59f1d24e893512928fa0627", "old_mode": 33188, "old_path": "pkg/kernel/lib/clone.dart", "new_id": "a407a138842c03301f09c9fba1dc62ad9f690225", "new_mode": 33188, "new_path": "pkg/kernel/lib/clone.dart" }, { "type": "modify", "old_id": "367b5d26fff59b75439007dd9fd658f3b457f30b", "old_mode": 33188, "old_path": "pkg/kernel/lib/external_name.dart", "new_id": "c93f975170a43f1c84266333d0e1f2633e8b698b", "new_mode": 33188, "new_path": "pkg/kernel/lib/external_name.dart" }, { "type": "modify", "old_id": "1c93f7c7d7d296bfdacc3686fc16e11fd477a9ca", "old_mode": 33188, "old_path": "pkg/kernel/lib/reference_from_index.dart", "new_id": "6182a4bd7ce1737f5a274aa1ddf737074b74ca00", "new_mode": 33188, "new_path": "pkg/kernel/lib/reference_from_index.dart" }, { "type": "modify", "old_id": "b307532414a679a998c390564b14a5020e4e561f", "old_mode": 33188, "old_path": "pkg/kernel/lib/src/equivalence.dart", "new_id": "4a163b9a8c24a56d009fed6df5591c12b62ebf19", "new_mode": 33188, "new_path": "pkg/kernel/lib/src/equivalence.dart" }, { "type": "modify", "old_id": "d05be909b405812a73de88ebfb54ad108dd9c83b", "old_mode": 33188, "old_path": "pkg/kernel/lib/transformations/mixin_full_resolution.dart", "new_id": "fee2089423769f7f36143243ae1b79211a35e778", "new_mode": 33188, "new_path": "pkg/kernel/lib/transformations/mixin_full_resolution.dart" }, { "type": "modify", "old_id": "cc4d1387419039bca5731ad88f49af747f265c53", "old_mode": 33188, "old_path": "pkg/kernel/lib/transformations/track_widget_constructor_locations.dart", "new_id": "318b7205654ae0a642355f9803e574c8f40bc8d9", "new_mode": 33188, "new_path": "pkg/kernel/lib/transformations/track_widget_constructor_locations.dart" }, { "type": "modify", "old_id": "2a8cfb64e5a9cf9e388b5cf7f2af0be8fdec08b4", "old_mode": 33188, "old_path": "pkg/kernel/test/clone_test.dart", "new_id": "5501551e408bd9a1744336ff19392bef0e30d349", "new_mode": 33188, "new_path": "pkg/kernel/test/clone_test.dart" }, { "type": "modify", "old_id": "715784563d5fe2701484397f6d159df3230fc623", "old_mode": 33188, "old_path": "pkg/vm/lib/transformations/ffi_definitions.dart", "new_id": "b0aa9a589e14a28dad92a480d3955f881aec7228", "new_mode": 33188, "new_path": "pkg/vm/lib/transformations/ffi_definitions.dart" }, { "type": "modify", "old_id": "3d44d461be2341178b981ca7a3819c893612d1a4", "old_mode": 33188, "old_path": "pkg/vm/lib/transformations/ffi_native.dart", "new_id": "0752ed29bd997be7240839ff99fbcdb8387c93d6", "new_mode": 33188, "new_path": "pkg/vm/lib/transformations/ffi_native.dart" }, { "type": "modify", "old_id": "dfac7137177035fa50fddfcb59b394627cfd1e86", "old_mode": 33188, "old_path": "pkg/vm/lib/transformations/pragma.dart", "new_id": "2fabcf4f8f561eb8558abd23a380ab90a4cae89c", "new_mode": 33188, "new_path": "pkg/vm/lib/transformations/pragma.dart" }, { "type": "modify", "old_id": "c0175a48d7ba303bb66658d92766a51fd5878347", "old_mode": 33188, "old_path": "pkg/vm/lib/transformations/type_flow/protobuf_handler.dart", "new_id": "ffc4b1e03c53b2438b3f2c81924fdc60d1d1b4c7", "new_mode": 33188, "new_path": "pkg/vm/lib/transformations/type_flow/protobuf_handler.dart" }, { "type": "modify", "old_id": "f37aa3aa2041080577a997c940e44ee79afb67c1", "old_mode": 33188, "old_path": "pkg/vm/lib/transformations/type_flow/transformer.dart", "new_id": "1868a4db620c8b41b178010aadf379021490b135", "new_mode": 33188, "new_path": "pkg/vm/lib/transformations/type_flow/transformer.dart" }, { "type": "modify", "old_id": "1623621e9bc0b5b2139d43dd75720d35add005c0", "old_mode": 33188, "old_path": "pkg/vm/test/incremental_compiler_test.dart", "new_id": "b24cb9e30dc7f1a68b32109c53b40e76c7223ec8", "new_mode": 33188, "new_path": "pkg/vm/test/incremental_compiler_test.dart" }, { "type": "modify", "old_id": "2ed7d1442ec66a52e4e992233f9a24e144716598", "old_mode": 33188, "old_path": "runtime/vm/compiler/frontend/constant_reader.cc", "new_id": "a6bc6e56a798ff7311dbe804286f92f3ca48f204", "new_mode": 33188, "new_path": "runtime/vm/compiler/frontend/constant_reader.cc" }, { "type": "modify", "old_id": "d74fc3d3f1d1ff303a5ddd8017e68106d665e1d3", "old_mode": 33188, "old_path": "runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc", "new_id": "8c1f3bc4074ba767f7bbb76ef5ca926cf558e54e", "new_mode": 33188, "new_path": "runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc" }, { "type": "modify", "old_id": "7406e5a321b365fed53fe49b3437ec9695525f50", "old_mode": 33188, "old_path": "runtime/vm/compiler/frontend/kernel_translation_helper.cc", "new_id": "db4e0745fde862e851ace923d098044116e161d1", "new_mode": 33188, "new_path": "runtime/vm/compiler/frontend/kernel_translation_helper.cc" }, { "type": "modify", "old_id": "d7e5542e1d368548efc3e13d131690a1ca0957be", "old_mode": 33188, "old_path": "runtime/vm/compiler/frontend/kernel_translation_helper.h", "new_id": "c854d0769a79377318cc32b584427cefe0425514", "new_mode": 33188, "new_path": "runtime/vm/compiler/frontend/kernel_translation_helper.h" }, { "type": "modify", "old_id": "13f777ca00a34c16a7bf12c3bbe5a30322e61776", "old_mode": 33188, "old_path": "runtime/vm/kernel_binary.h", "new_id": "65b7bd55706dddce6ad30e11f59632c4ac8401ee", "new_mode": 33188, "new_path": "runtime/vm/kernel_binary.h" }, { "type": "modify", "old_id": "d8b817c5eb419b93fcaeb4cb495a02d4fba19659", "old_mode": 33188, "old_path": "tests/standalone/check_for_aot_snapshot_jit_test.dart", "new_id": "92f39cda75c89bdf08422b9715ca7b30696b6592", "new_mode": 33188, "new_path": "tests/standalone/check_for_aot_snapshot_jit_test.dart" }, { "type": "modify", "old_id": "e9c3e244c5c905623a04b95be66f4aaae3351e12", "old_mode": 33188, "old_path": "tests/standalone_2/check_for_aot_snapshot_jit_test.dart", "new_id": "d446a7be7a0fdf82654bd387169b3d14d1a652da", "new_mode": 33188, "new_path": "tests/standalone_2/check_for_aot_snapshot_jit_test.dart" } ] }