Roll Clang from 0454dd8c48cd to 8c7a2ce01a77
TEST=ci
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
Change-Id: I9d4e7abe9541f74a67e469c4ba4ba3cecfaec431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427280
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
diff --git a/DEPS b/DEPS
index d584abd..df7440e 100644
--- a/DEPS
+++ b/DEPS
@@ -76,7 +76,7 @@
"jsc_tag": "version:294346",
# https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang
- "clang_version": "git_revision:0454dd8c48cd771478f1ae53330ba78e71bcd7cb",
+ "clang_version": "git_revision:8c7a2ce01a77c96028fe2c8566f65c45ad9408d3",
# https://chrome-infra-packages.appspot.com/p/gn/gn
"gn_version": "git_revision:487f8353f15456474437df32bb186187b0940b45",
diff --git a/runtime/platform/no_tsan.h b/runtime/platform/no_tsan.h
index 9e65a1b..fe22482 100644
--- a/runtime/platform/no_tsan.h
+++ b/runtime/platform/no_tsan.h
@@ -23,22 +23,21 @@
#if defined(__GNUC__)
__attribute__((no_sanitize("thread")))
#endif
-inline uintptr_t
-FetchAndRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr, uintptr_t value) {
+inline uintptr_t FetchAndRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr,
+ uintptr_t value) {
return ptr->fetch_and(value, std::memory_order_relaxed);
}
#if defined(__GNUC__)
__attribute__((no_sanitize("thread")))
#endif
-inline uintptr_t
-FetchOrRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr, uintptr_t value) {
+inline uintptr_t FetchOrRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr,
+ uintptr_t value) {
return ptr->fetch_or(value, std::memory_order_relaxed);
}
#if defined(__GNUC__)
__attribute__((no_sanitize("thread")))
#endif
-inline uintptr_t
-LoadRelaxedIgnoreRace(const std::atomic<uintptr_t>* ptr) {
+inline uintptr_t LoadRelaxedIgnoreRace(const std::atomic<uintptr_t>* ptr) {
return ptr->load(std::memory_order_relaxed);
}
#endif
diff --git a/runtime/platform/utils.h b/runtime/platform/utils.h
index a6cd3db..dd63212 100644
--- a/runtime/platform/utils.h
+++ b/runtime/platform/utils.h
@@ -492,15 +492,13 @@
#ifdef __GNUC__
__attribute__((no_sanitize("float-divide-by-zero")))
#endif
- static inline float
- DivideAllowZero(float a, float b) {
+ static inline float DivideAllowZero(float a, float b) {
return a / b;
}
#ifdef __GNUC__
__attribute__((no_sanitize("float-divide-by-zero")))
#endif
- static inline double
- DivideAllowZero(double a, double b) {
+ static inline double DivideAllowZero(double a, double b) {
return a / b;
}
diff --git a/runtime/vm/compiler/backend/constant_propagator.cc b/runtime/vm/compiler/backend/constant_propagator.cc
index 9123ab9..7ad610c 100644
--- a/runtime/vm/compiler/backend/constant_propagator.cc
+++ b/runtime/vm/compiler/backend/constant_propagator.cc
@@ -34,8 +34,8 @@
unknown_(Object::unknown_constant()),
non_constant_(Object::non_constant()),
constant_value_(Object::Handle(Z)),
- reachable_(new(Z) BitVector(Z, graph->preorder().length())),
- unwrapped_phis_(new(Z) BitVector(Z, graph->current_ssa_temp_index())),
+ reachable_(new (Z) BitVector(Z, graph->preorder().length())),
+ unwrapped_phis_(new (Z) BitVector(Z, graph->current_ssa_temp_index())),
block_worklist_(),
definition_worklist_(graph, 10) {}
diff --git a/runtime/vm/compiler/backend/il.cc b/runtime/vm/compiler/backend/il.cc
index e40ede1..6e35274 100644
--- a/runtime/vm/compiler/backend/il.cc
+++ b/runtime/vm/compiler/backend/il.cc
@@ -1246,7 +1246,7 @@
ConstantInstr* GraphEntryInstr::constant_null() {
ASSERT(initial_definitions()->length() > 0);
for (intptr_t i = 0; i < initial_definitions()->length(); ++i) {
- ConstantInstr* defn = (*initial_definitions())[i]->AsConstant();
+ ConstantInstr* defn = (*initial_definitions())[i] -> AsConstant();
if (defn != nullptr && defn->value().IsNull()) return defn;
}
UNREACHABLE();
diff --git a/runtime/vm/compiler/backend/il.h b/runtime/vm/compiler/backend/il.h
index dae7cfb..745c4b2 100644
--- a/runtime/vm/compiler/backend/il.h
+++ b/runtime/vm/compiler/backend/il.h
@@ -5918,7 +5918,7 @@
class MakeTempInstr : public TemplateDefinition<0, NoThrow, Pure> {
public:
explicit MakeTempInstr(Zone* zone)
- : null_(new(zone) ConstantInstr(Object::ZoneHandle())) {
+ : null_(new (zone) ConstantInstr(Object::ZoneHandle())) {
// Note: We put ConstantInstr inside MakeTemp to simplify code generation:
// having ConstantInstr allows us to use Location::Constant(null_) as an
// output location for this instruction.
diff --git a/runtime/vm/compiler/backend/il_printer.cc b/runtime/vm/compiler/backend/il_printer.cc
index f8fa088..6a27c20 100644
--- a/runtime/vm/compiler/backend/il_printer.cc
+++ b/runtime/vm/compiler/backend/il_printer.cc
@@ -1467,7 +1467,7 @@
for (intptr_t i = 0; i < phis()->length(); ++i) {
if ((*phis())[i] == nullptr) continue;
f->AddString("\n ");
- (*phis())[i]->PrintTo(f);
+ (*phis())[i] -> PrintTo(f);
}
f->AddString("\n}");
}
diff --git a/runtime/vm/compiler/backend/inliner.cc b/runtime/vm/compiler/backend/inliner.cc
index 1493905..e3a093a 100644
--- a/runtime/vm/compiler/backend/inliner.cc
+++ b/runtime/vm/compiler/backend/inliner.cc
@@ -1959,9 +1959,9 @@
num_variants_(call->NumberOfChecks()),
variants_(call->targets_),
inlined_variants_(zone()),
- non_inlined_variants_(new(zone()) CallTargets(zone())),
+ non_inlined_variants_(new (zone()) CallTargets(zone())),
inlined_entries_(num_variants_),
- exit_collector_(new(Z) InlineExitCollector(owner->caller_graph(), call)),
+ exit_collector_(new (Z) InlineExitCollector(owner->caller_graph(), call)),
caller_function_(caller_function) {}
IsolateGroup* PolymorphicInliner::isolate_group() const {
diff --git a/runtime/vm/compiler/backend/redundancy_elimination.cc b/runtime/vm/compiler/backend/redundancy_elimination.cc
index 0724d44..5c80e41 100644
--- a/runtime/vm/compiler/backend/redundancy_elimination.cc
+++ b/runtime/vm/compiler/backend/redundancy_elimination.cc
@@ -774,7 +774,7 @@
typed_data_access_sizes_(),
representatives_(),
killed_(),
- aliased_by_effects_(new(zone) BitVector(zone, places->length())) {
+ aliased_by_effects_(new (zone) BitVector(zone, places->length())) {
InsertAlias(Place::CreateAnyInstanceAnyIndexAlias(
zone_, kAnyInstanceAnyIndexAlias));
for (intptr_t i = 0; i < places_.length(); i++) {
diff --git a/runtime/vm/compiler/backend/type_propagator.cc b/runtime/vm/compiler/backend/type_propagator.cc
index ece6e50..b069701 100644
--- a/runtime/vm/compiler/backend/type_propagator.cc
+++ b/runtime/vm/compiler/backend/type_propagator.cc
@@ -49,7 +49,7 @@
: FlowGraphVisitor(flow_graph->reverse_postorder()),
flow_graph_(flow_graph),
is_aot_(CompilerState::Current().is_aot()),
- visited_blocks_(new(flow_graph->zone())
+ visited_blocks_(new (flow_graph->zone())
BitVector(flow_graph->zone(),
flow_graph->reverse_postorder().length())),
types_(flow_graph->current_ssa_temp_index()),
diff --git a/runtime/vm/deopt_instructions.cc b/runtime/vm/deopt_instructions.cc
index 43453e4..398a76c 100644
--- a/runtime/vm/deopt_instructions.cc
+++ b/runtime/vm/deopt_instructions.cc
@@ -968,7 +968,7 @@
instructions_(),
num_args_(num_args),
assembler_(assembler),
- trie_root_(new(zone) TrieNode()),
+ trie_root_(new (zone) TrieNode()),
current_info_number_(0),
frame_start_(-1),
materializations_() {}
diff --git a/runtime/vm/elf.cc b/runtime/vm/elf.cc
index 0cea903..791d4b8 100644
--- a/runtime/vm/elf.cc
+++ b/runtime/vm/elf.cc
@@ -1178,7 +1178,7 @@
unwrapped_stream_(stream),
type_(type),
dwarf_(dwarf),
- section_table_(new(zone) SectionTable(zone)) {
+ section_table_(new (zone) SectionTable(zone)) {
// Separate debugging information should always have a Dwarf object.
ASSERT(type_ == Type::Snapshot || dwarf_ != nullptr);
// Assumed by various offset logic in this file.
@@ -1263,7 +1263,7 @@
DwarfElfStream(Zone* zone, NonStreamingWriteStream* stream)
: zone_(ASSERT_NOTNULL(zone)),
stream_(ASSERT_NOTNULL(stream)),
- relocations_(new(zone) ZoneGrowableArray<Elf::Relocation>()) {}
+ relocations_(new (zone) ZoneGrowableArray<Elf::Relocation>()) {}
const uint8_t* buffer() const { return stream_->buffer(); }
intptr_t bytes_written() const { return stream_->bytes_written(); }
diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc
index d8cce65..d4ee65c 100644
--- a/runtime/vm/exceptions.cc
+++ b/runtime/vm/exceptions.cc
@@ -572,12 +572,11 @@
}
NO_SANITIZE_SAFE_STACK // This function manipulates the safestack pointer.
- void
- Exceptions::JumpToFrame(Thread* thread,
- uword program_counter,
- uword stack_pointer,
- uword frame_pointer,
- bool clear_deopt_at_target) {
+ void Exceptions::JumpToFrame(Thread* thread,
+ uword program_counter,
+ uword stack_pointer,
+ uword frame_pointer,
+ bool clear_deopt_at_target) {
ASSERT(thread->execution_state() == Thread::kThreadInVM);
const uword fp_for_clearing =
diff --git a/runtime/vm/regexp/regexp.h b/runtime/vm/regexp/regexp.h
index 3675b9e..be1b827 100644
--- a/runtime/vm/regexp/regexp.h
+++ b/runtime/vm/regexp/regexp.h
@@ -657,7 +657,7 @@
bool read_backward,
RegExpNode* on_success)
: SeqRegExpNode(on_success),
- elms_(new(zone()) ZoneGrowableArray<TextElement>(1)),
+ elms_(new (zone()) ZoneGrowableArray<TextElement>(1)),
read_backward_(read_backward) {
elms_->Add(TextElement::CharClass(that));
}
@@ -895,7 +895,7 @@
public:
explicit ChoiceNode(intptr_t expected_size, Zone* zone)
: RegExpNode(zone),
- alternatives_(new(zone)
+ alternatives_(new (zone)
ZoneGrowableArray<GuardedAlternative>(expected_size)),
not_at_start_(false),
being_calculated_(false) {}
@@ -1096,7 +1096,7 @@
class BoyerMoorePositionInfo : public ZoneAllocated {
public:
explicit BoyerMoorePositionInfo(Zone* zone)
- : map_(new(zone) ZoneGrowableArray<bool>(kMapSize)),
+ : map_(new (zone) ZoneGrowableArray<bool>(kMapSize)),
map_count_(0),
w_(kNotYet),
s_(kNotYet),
diff --git a/runtime/vm/regexp/regexp_ast.cc b/runtime/vm/regexp/regexp_ast.cc
index 3bfd878..884fed9 100644
--- a/runtime/vm/regexp/regexp_ast.cc
+++ b/runtime/vm/regexp/regexp_ast.cc
@@ -145,7 +145,7 @@
OS::PrintErr("(|");
for (intptr_t i = 0; i < that->alternatives()->length(); i++) {
OS::PrintErr(" ");
- (*that->alternatives())[i]->Accept(this, data);
+ (*that->alternatives())[i] -> Accept(this, data);
}
OS::PrintErr(")");
return nullptr;
@@ -155,7 +155,7 @@
OS::PrintErr("(:");
for (intptr_t i = 0; i < that->nodes()->length(); i++) {
OS::PrintErr(" ");
- (*that->nodes())[i]->Accept(this, data);
+ (*that->nodes())[i] -> Accept(this, data);
}
OS::PrintErr(")");
return nullptr;
diff --git a/runtime/vm/regexp/regexp_parser.h b/runtime/vm/regexp/regexp_parser.h
index 72c3f2f..16932e5 100644
--- a/runtime/vm/regexp/regexp_parser.h
+++ b/runtime/vm/regexp/regexp_parser.h
@@ -164,7 +164,7 @@
RegExpFlags flags,
Zone* zone)
: previous_state_(previous_state),
- builder_(new(zone) RegExpBuilder(flags)),
+ builder_(new (zone) RegExpBuilder(flags)),
group_type_(group_type),
lookaround_type_(lookaround_type),
disjunction_capture_index_(disjunction_capture_index),
diff --git a/runtime/vm/scopes.cc b/runtime/vm/scopes.cc
index 50b3ba7..f0fe0df 100644
--- a/runtime/vm/scopes.cc
+++ b/runtime/vm/scopes.cc
@@ -31,7 +31,7 @@
end_token_pos_(TokenPosition::kNoSource),
variables_(),
context_variables_(),
- context_slots_(new(Thread::Current()->zone())
+ context_slots_(new (Thread::Current()->zone())
ZoneGrowableArray<const Slot*>()) {
// Hook this node into the children of the parent, unless the parent has a
// different function_level, since the local scope of a nested function can
diff --git a/runtime/vm/v8_snapshot_writer.h b/runtime/vm/v8_snapshot_writer.h
index 405109b..6cd20bc 100644
--- a/runtime/vm/v8_snapshot_writer.h
+++ b/runtime/vm/v8_snapshot_writer.h
@@ -233,7 +233,7 @@
intptr_t type = kInvalidString,
intptr_t name = kInvalidString)
: id(id),
- edges(new(profile_writer->zone_) EdgeMap(profile_writer->zone_)),
+ edges(new (profile_writer->zone_) EdgeMap(profile_writer->zone_)),
type(type),
name(name) {}
