| commit | e6e88c719c8e5e45e5802c0c393b2b3476f1e8b5 | [log] [tgz] |
|---|---|---|
| author | Vyacheslav Egorov <vegorov@google.com> | Tue Nov 27 11:10:49 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Nov 27 11:10:49 2018 +0000 |
| tree | 452ff477da1191becc912e593ca91cf6bf7eaee1 | |
| parent | 797334a531bca7e89555922c1769220c3791c312 [diff] |
[gardening] Make standalone_2/io/http_loopback_test more robust. This test checks that we should not be able to connect to server listening on IPv4 via IPv6 and vice versa. However by chance some other test might start listening on the same port as this test is using, just using different protocol. In this case the test will fail. To make this test more robust we add a check which verifies that server did not actually see the connection from the client with a matching port (we compare client's port to remotePort that server saw). After these changes we only should fail this test if we indeed managed to connect to the loopback server using a mismatching protocol. Fixes https://github.com/dart-lang/sdk/issues/30700 Change-Id: Ib4f3d0346030dcffaac44ff5dd4050939984b1fc Reviewed-on: https://dart-review.googlesource.com/c/85389 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.