| commit | 57d0376d671b9c9a9abda25c344777aad0916ab1 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Fri Oct 28 11:53:58 2022 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 28 11:53:58 2022 +0000 |
| tree | ed7ba641889464a35c2fa6e38e56f649bce49ef4 | |
| parent | 47cb34d8b993efb9f58439a5ce0955aa3e33d9d9 [diff] |
[CFE] Fix 'Found failures!' message not being last in weekly test
We delay the execution of the second leak test ("leak test alternative
invalidation") to ensure the first one has fetched pub packages and
avoid both of them trying to do the same thing at the same time, or one
thinking it has been done when it's not actually done yet etc). If this
is slow or there's a crash it waits for at most 10 minutes before
launching the second iteration.
In those 10 minutes, though, it can have started waiting for all other
tests to finish and once they have, if any failed, print the
"Found failures!" (and what has failed of those) mixed in with all the
output from the leak test.
Technically, if the other tests finished within the 10 minutes (they
won't) it might even make it look like there are no failures even if the
second leak tests fails.
This CL fixes the issue by first awaiting the start of the second leak
test before awaiting the finishing of all started processes.
Change-Id: Iaace924346aa2bb4b8c6e025bd53e95e6a414a34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266021
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.